You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/07/22 07:49:49 UTC
Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
TSentryPrivilege.java is auto-generate by thrift.
Diffs
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
Diff: https://reviews.apache.org/r/23788/diff/
Testing
-------
Thanks,
Sun Dapeng
Re: Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On July 28, 2014, 10:37 p.m., Sravya Tirukkovalur wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift, line 49
> > <https://reviews.apache.org/r/23788/diff/1-2/?file=638814#file638814line49>
> >
> > I am not a thrift expert, but looks like thrift does support bool: http://wiki.apache.org/thrift/Tutorial
> >
> > Also, can you update the patch on the jira as well?
Discussed this on a different jira, so we can close this issue.
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/#review48922
-----------------------------------------------------------
On July 28, 2014, 10:06 a.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23788/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 10:06 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TSentryGrantOption.java and TSentryPrivilege.java are auto-generate by thrift.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
>
> Diff: https://reviews.apache.org/r/23788/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/#review48922
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
<https://reviews.apache.org/r/23788/#comment85714>
I am not a thrift expert, but looks like thrift does support bool: http://wiki.apache.org/thrift/Tutorial
Also, can you update the patch on the jira as well?
- Sravya Tirukkovalur
On July 28, 2014, 10:06 a.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23788/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 10:06 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TSentryGrantOption.java and TSentryPrivilege.java are auto-generate by thrift.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
>
> Diff: https://reviews.apache.org/r/23788/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/#review49054
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On July 28, 2014, 10:06 a.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23788/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 10:06 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TSentryGrantOption.java and TSentryPrivilege.java are auto-generate by thrift.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
>
> Diff: https://reviews.apache.org/r/23788/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/
-----------------------------------------------------------
(Updated July 28, 2014, 6:06 p.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Because thrift do not support Boolean, so make GrantOption as an ENUM type
Repository: sentry
Description (updated)
-------
TSentryGrantOption.java and TSentryPrivilege.java are auto-generate by thrift.
Diffs
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
Diff: https://reviews.apache.org/r/23788/diff/
Testing
-------
Thanks,
Sun Dapeng
Re: Review Request 23788: SENTRY-341 Extend Thrift API for SentryStore to
support "with grant option"
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23788/
-----------------------------------------------------------
(Updated July 28, 2014, 5:57 p.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
TSentryPrivilege.java is auto-generate by thrift.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c
Diff: https://reviews.apache.org/r/23788/diff/
Testing
-------
Thanks,
Sun Dapeng