You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by kkasravi <gi...@git.apache.org> on 2016/11/09 21:30:39 UTC
[GitHub] incubator-gearpump pull request #109: Fixes GEARPUMP-234 Update LICENSE and ...
GitHub user kkasravi opened a pull request:
https://github.com/apache/incubator-gearpump/pull/109
Fixes GEARPUMP-234 Update LICENSE and related files for 0.8.2-incubat\u2026
\u2026ing binary release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit 886aa48119427c342e2f4e6e0e062a85cee4e79d
Author: Kam Kasravi <ka...@yahoo.com>
Date: 2016-11-09T00:24:31Z
Fixes GEARPUMP-234 Update LICENSE and related files for 0.8.2-incubating binary release
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #109: Fixes GEARPUMP-234 Update LICENSE and ...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/109#discussion_r87539905
--- Diff: LICENSE.bin ---
@@ -0,0 +1,349 @@
+ Apache License
--- End diff --
why the file extension is `bin` ? Is this auto generated ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #109: Fixes GEARPUMP-234 Update LICENSE and ...
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/109#discussion_r87679023
--- Diff: LICENSE.bin ---
@@ -0,0 +1,349 @@
+ Apache License
--- End diff --
@manuzhang we were dinged during or 0.8.1 release when one of the rejecting apache voters said we shouldn't include binary licenses unless we're releasing binary artifacts. So we need to have a LICENSE file for source and a LICENSE file for binary. In this case when I build the binary tar.gz I copy the LICENSE.bin to LICENSE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:
https://github.com/apache/incubator-gearpump/pull/109
@manuzhang Let's wait for #108 as you noted above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/109
LGTM, can we wait for https://github.com/apache/incubator-gearpump/pull/108 to go in first ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...
Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:
https://github.com/apache/incubator-gearpump/pull/109
@manuzhang looks like #108 is in. I'll add the JIRA to CHANGELOG.md and recreate the artifacts. Do you remember if I used 0.8.1.RC[0-9] for version or 0.8.1? I'll look at the github history...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #109: Fixes GEARPUMP-234 Update LICENSE and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #109: Fixes GEARPUMP-234 Update LICENSE and related...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/109
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/109?src=pr) is 72.32% (diff: 100%)
> Merging [#109](https://codecov.io/gh/apache/incubator-gearpump/pull/109?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.58%**
```diff
@@ master #109 diff @@
==========================================
Files 186 186
Lines 5981 5981
Methods 5456 5456
Messages 0 0
Branches 525 525
==========================================
+ Hits 4291 4326 +35
+ Misses 1690 1655 -35
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [cbf59fb...886aa48](https://codecov.io/gh/apache/incubator-gearpump/compare/cbf59fb77834914116657a135b30899b91a7408d...886aa48119427c342e2f4e6e0e062a85cee4e79d?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---