[jira] [Commented] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796858#comment-15796858 ] 

James Taylor commented on PHOENIX-3413:
---------------------------------------

[~kliew] - would you be able to take this one?

> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-3413
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3413
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>         if (maxLength == null) {
>             maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
>         }
> {code}
> The null check for type is ineffective - type is de-referenced in various places prior to the above check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)