You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/07/07 18:18:36 UTC

[GitHub] [incubator-gobblin] aryavaibhav93 opened a new pull request #3055: Making dataset name as part of staging directory in gobblin-distcp (file-based)

aryavaibhav93 opened a new pull request #3055:
URL: https://github.com/apache/incubator-gobblin/pull/3055


   …ile-based)
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   https://jira01.corp.linkedin.com:8443/browse/ETL-10950
   
   
   ### Description
   Currently, Embedded distcp creates it's own temp or user defined staging directory. But, this PR adds the option to have a staging directory which is being created within datasets.
   
   
   ### Tests
   My PR incorporates change to the following unit tests:
   FileAwareInputStreamDataWriterTest.java
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org