You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiang13021 (via GitHub)" <gi...@apache.org> on 2024/07/19 05:18:38 UTC
[PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
jiang13021 opened a new pull request, #2638:
URL: https://github.com/apache/celeborn/pull/2638
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add a unit test for https://github.com/apache/celeborn/pull/2235
### Why are the changes needed?
ditto
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
org.apache.celeborn.tests.spark.CelebornWorkerRestartSuite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2376305197
This issue was closed because it has been staled for 10 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2298287527
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2638: [CELEBORN-1233] Add unit test to verify data correctness
URL: https://github.com/apache/celeborn/pull/2638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2259810293
> ping @waitinfuture @RexXiong Please take a look. Thanks.
see comments at https://github.com/apache/celeborn/pull/2609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2352308193
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "jiang13021 (via GitHub)" <gi...@apache.org>.
jiang13021 commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2311486557
> > ping @waitinfuture @RexXiong Please take a look. Thanks.
>
> see comments at #2609
Hi, we found that without CELEBORN-1233's PR: #2235 , if a file is deleted, the worker won't throw an exception and this could lead to data correctness issues. There is no unit test for CELEBORN-1233, so I have written one. However, it is not a unit test for #2609.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1233] Add unit test to verify data correctness [celeborn]
Posted by "jiang13021 (via GitHub)" <gi...@apache.org>.
jiang13021 commented on PR #2638:
URL: https://github.com/apache/celeborn/pull/2638#issuecomment-2257348191
ping @waitinfuture @RexXiong Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org