You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/10 18:18:03 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4782: sem: remove limitation of irq context when do sem_trywait

xiaoxiang781216 commented on a change in pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#discussion_r746864219



##########
File path: sched/semaphore/sem_trywait.c
##########
@@ -69,10 +69,6 @@ int nxsem_trywait(FAR sem_t *sem)
   irqstate_t flags;
   int ret;
 
-  /* This API should not be called from interrupt handlers */

Review comment:
       Since the behavior change happen only when CONFIG_DEBUG_MM is defined, we can simply to:
   
   1. #ifndef CONFIG_DEBUG_MM the below debug assert
   2. keep _SEM_TRYWAIT in mm/mm_heap/mm_sem.c with CONFIG_DEBUG_MM guard
   3. Remove all other assert
   
   Do you think so? @davids5 .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org