You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/28 03:53:13 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #219: Add dist to build

atoulme opened a new pull request #219:
URL: https://github.com/apache/incubator-tuweni/pull/219


   ## PR description
   Add dist build folder to the mounted folders when running build.sh, so folks can get the distributions by following the build.sh script
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #219: Add dist to build

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #219:
URL: https://github.com/apache/incubator-tuweni/pull/219#issuecomment-828126649


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#219](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c8c499) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/7fc9a69b0b8e72d562a8827cdb35a510b5300a1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fc9a69) will **increase** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/219/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #219      +/-   ##
   ============================================
   + Coverage     60.25%   60.35%   +0.09%     
     Complexity     4003     4003              
   ============================================
     Files           385      385              
     Lines         21451    21422      -29     
     Branches       2860     2854       -6     
   ============================================
   + Hits          12926    12929       +3     
   + Misses         7073     7044      -29     
   + Partials       1452     1449       -3     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | unit | `60.35% <ø> (+0.09%)` | `4003.00 <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `50.00% <0.00%> (-10.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `80.85% <0.00%> (+2.12%)` | `0.00% <0.00%> (ø%)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `51.00% <0.00%> (+3.33%)` | `0.00% <0.00%> (ø%)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `82.90% <0.00%> (+3.41%)` | `14.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7fc9a69...5c8c499](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #219: Add dist to build

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #219:
URL: https://github.com/apache/incubator-tuweni/pull/219#issuecomment-828126649


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#219](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c8c499) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/7fc9a69b0b8e72d562a8827cdb35a510b5300a1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fc9a69) will **increase** coverage by `4.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/219/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #219      +/-   ##
   ============================================
   + Coverage     60.25%   64.91%   +4.65%     
   - Complexity     4003     4315     +312     
   ============================================
     Files           385      410      +25     
     Lines         21451    21803     +352     
     Branches       2860     2861       +1     
   ============================================
   + Hits          12926    14154    +1228     
   + Misses         7073     6080     -993     
   - Partials       1452     1569     +117     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `48.02% <ø> (?)` | `645.00 <ø> (?)` | |
   | unit | `60.35% <ø> (+0.09%)` | `4003.00 <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `50.00% <0.00%> (-10.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `73.46% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...tuweni/scuttlebutt/lib/model/query/AboutQuery.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9xdWVyeS9BYm91dFF1ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [.../apache/tuweni/scuttlebutt/lib/NetworkService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9OZXR3b3JrU2VydmljZS5qYXZh) | `22.44% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
   | [...ache/tuweni/scuttlebutt/lib/model/FeedMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9GZWVkTWVzc2FnZS5qYXZh) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
   | [...weni/scuttlebutt/lib/ScuttlebuttClientFactory.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9TY3V0dGxlYnV0dENsaWVudEZhY3RvcnkuamF2YQ==) | `41.17% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
   | [...ttlebutt/lib/model/CouldNotSerializeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9Db3VsZE5vdFNlcmlhbGl6ZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...apache/tuweni/scuttlebutt/lib/model/FeedValue.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9GZWVkVmFsdWUuamF2YQ==) | `75.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
   | [...rc/main/kotlin/org/apache/tuweni/ethclientui/UI.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC11aS9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50dWkvVUkua3Q=) | `92.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
   | [...cuttlebutt/lib/model/query/AboutQueryResponse.java](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9xdWVyeS9BYm91dFF1ZXJ5UmVzcG9uc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/219/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7fc9a69...5c8c499](https://codecov.io/gh/apache/incubator-tuweni/pull/219?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] atoulme merged pull request #219: Add dist to build

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #219:
URL: https://github.com/apache/incubator-tuweni/pull/219


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org