You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by James Morris <jm...@intercode.com.au> on 1999/04/08 06:04:12 UTC
[PATCH] (apache-apr) mod_info fix
Below is a patch which allows mod_info to work again for apache-apr
(snapshot 19990408011444).
A problem with data passed to va_arg() was causing a segfault in a thread
and the request to hang. Is there a better way to dispose of a request if
the thread handling it dies?
- James.
--
James Morris
<jm...@intercode.com.au>
diff -r --unified=3 apache-apr-19990408011444/pthreads/src/modules/standard/mod_info.c apache-apr-new/pthreads/src/modules/standard/mod_info.c
--- apache-apr-19990408011444/pthreads/src/modules/standard/mod_info.c Sun Feb 7 19:14:11 1999
+++ apache-apr-new/pthreads/src/modules/standard/mod_info.c Thu Apr 8 13:47:52 1999
@@ -425,7 +425,8 @@
ap_rprintf(r, "<strong>Max Requests:</strong> "
"<tt>per child: %d "
"keep alive: %s "
- "max per connection: </tt><br>\n",
+ "max per connection: %d</tt><br>\n",
+ ap_max_requests_per_child,
(serv->keep_alive ? "on" : "off"),
serv->keep_alive_max);
ap_rprintf(r, "<strong>Threads:</strong> "
Re: [PATCH] (apache-apr) mod_info fix
Posted by Manoj Kasichainula <ma...@raleigh.ibm.com>.
On Thu, Apr 08, 1999 at 02:04:12PM +1000, James Morris wrote:
> Below is a patch which allows mod_info to work again for apache-apr
> (snapshot 19990408011444).
It's committed. Thanks!
> Is there a better way to dispose of a request if the thread handling
> it dies?
Not right now. It's just like the situation in process-based Apache
when a process dies. If a thread segfaults, the whole process dies,
and there is no way for another process to grab the file descriptor,
figure out the stage the request was in, and complete the request
properly.
So segfaults are very very bad.
Manoj