[GitHub] [ozone] xichen01 commented on pull request #4574: HDDS-8428. Inconsistent Metrics units in CMSMetrics

["xichen01 (via GitHub)" <gi...@apache.org>]

xichen01 commented on PR #4574:
URL: https://github.com/apache/ozone/pull/4574#issuecomment-1510965596

   > @xichen01 , do you aware the common value of applyTransaction and writeStateMachineData? Are their value always higher than 1ms?
   
   I mainly want to standardize the units of metrics, in `CMSMetrics`, some metrics are in `ms` and some are in `ns`, which is not directly known from the names of the metrics, which may cause misunderstanding.
   
   According to my observation the average value  `writeStateMachineData`  is usually 1~10ms, the average value of `applyTransaction` is usually less than 1ms, but the maximum value of both is more than 1ms.
   
   For values under 1ms, whether we can consider as normal, need not to care? So a uniform unit of metrics is more friendly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org