You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2015/11/27 12:30:18 UTC
svn commit: r1716838 -
/poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java
Author: onealj
Date: Fri Nov 27 11:30:18 2015
New Revision: 1716838
URL: http://svn.apache.org/viewvc?rev=1716838&view=rev
Log:
+FIXME
Modified:
poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java
Modified: poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java?rev=1716838&r1=1716837&r2=1716838&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/SheetUtil.java Fri Nov 27 11:30:18 2015
@@ -103,6 +103,8 @@ public class SheetUtil {
Row row = cell.getRow();
int column = cell.getColumnIndex();
+ // FIXME: this looks very similar to getCellWithMerges below. Consider consolidating.
+ // We should only be checking merged regions if useMergedCells is true. Why are we doing this for-loop?
int colspan = 1;
for (CellRangeAddress region : sheet.getMergedRegions()) {
if (containsCell(region, row.getRowNum(), column)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org