You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/21 15:55:23 UTC

[GitHub] [incubator-linkis] huangxiaopingRD opened a new pull request, #3500: Supports startup script parameters compatible with multiple names of publicservice

huangxiaopingRD opened a new pull request, #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500

   Related issues: https://github.com/apache/incubator-linkis/issues/3499
   
   Test case:
   <img width="606" alt="image" src="https://user-images.githubusercontent.com/35296098/191552578-e693d292-bf59-42de-b2e7-a8c6013d449b.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] huangxiaopingRD commented on pull request #3500: Supports startup script parameters compatible with multiple names of publicservice

Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500#issuecomment-1253909679

   @casionone  Can you help with a review? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] huangxiaopingRD commented on pull request #3500: Supports startup script parameters compatible with multiple names of publicservice

Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500#issuecomment-1254848661

   > 
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] casionone commented on pull request #3500: Supports startup script parameters compatible with multiple names of publicservice

Posted by GitBox <gi...@apache.org>.
casionone commented on PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500#issuecomment-1254547869

   Other service names can also be supported together 
   ```
   linkis-cg-engineconnmanager
   linkis-cg-engineplugin
   linkis-cg-entrance
   linkis-cg-linkismanager
   linkis-mg-gateway
   linkis-ps-publicservice
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] casionone merged pull request #3500: Support startup scripts compatible with multiple service names

Posted by GitBox <gi...@apache.org>.
casionone merged PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] huangxiaopingRD commented on pull request #3500: Supports startup script parameters compatible with multiple names of publicservice

Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500#issuecomment-1254849084

   > Other service names can also be supported together
   > 
   > ```
   > linkis-cg-engineconnmanager
   > linkis-cg-engineplugin
   > linkis-cg-entrance
   > linkis-cg-linkismanager
   > linkis-mg-gateway
   > linkis-ps-publicservice
   > ```
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3500: Supports startup script parameters compatible with multiple names of publicservice

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3500:
URL: https://github.com/apache/incubator-linkis/pull/3500#issuecomment-1253940476

   # [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3500?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3500](https://codecov.io/gh/apache/incubator-linkis/pull/3500?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b54c3a9) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/6cb28d657f329476557b953273aa1fe98c52dd63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cb28d6) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@               Coverage Diff               @@
   ##             dev-1.3.1    #3500      +/-   ##
   ===============================================
   - Coverage        14.27%   14.26%   -0.01%     
   + Complexity        1256     1255       -1     
   ===============================================
     Files              820      820              
     Lines            31613    31613              
     Branches          4676     4676              
   ===============================================
   - Hits              4512     4510       -2     
   - Misses           26451    26453       +2     
     Partials           650      650              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `30.90% <0.00%> (-1.82%)` | :arrow_down: |
   | [...n/engineconn/EngineConnExecutorErrorException.java](https://codecov.io/gh/apache/incubator-linkis/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL2V4Y2VwdGlvbi9lbmdpbmVjb25uL0VuZ2luZUNvbm5FeGVjdXRvckVycm9yRXhjZXB0aW9uLmphdmE=) | | |
   | [...eption/engineconn/EngineConnExecutorErrorCode.java](https://codecov.io/gh/apache/incubator-linkis/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL2V4Y2VwdGlvbi9lbmdpbmVjb25uL0VuZ2luZUNvbm5FeGVjdXRvckVycm9yQ29kZS5qYXZh) | | |
   | [...eption/engineconn/EngineConnExecutorErrorCode.java](https://codecov.io/gh/apache/incubator-linkis/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvZ292ZXJuYW5jZS9leGNlcHRpb24vZW5naW5lY29ubi9FbmdpbmVDb25uRXhlY3V0b3JFcnJvckNvZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...n/engineconn/EngineConnExecutorErrorException.java](https://codecov.io/gh/apache/incubator-linkis/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvZ292ZXJuYW5jZS9leGNlcHRpb24vZW5naW5lY29ubi9FbmdpbmVDb25uRXhlY3V0b3JFcnJvckV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org