You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/16 15:23:15 UTC
[GitHub] [iceberg] mayursrivastava opened a new issue #2484: Fix ArrowReader to return Arrow vectors with logical Iceberg data type instead of physical
mayursrivastava opened a new issue #2484:
URL: https://github.com/apache/iceberg/issues/2484
For reference, the ArrowReader was added in https://github.com/apache/iceberg/pull/2286.
Columns with constant values are physically encoded as a dictionary. During reads, the Arrow vector type is int32 instead of the type as per the Iceberg table schema. Fix the ArrowReader and related code to return the Arrow vector corresponding to the logical data type.
After fixing it, remove ignore annotation from ArrowReaderTest#testReadAllWithConstantRecords().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mayursrivastava commented on issue #2484: Fix ArrowReader to return Arrow vectors with logical Iceberg data type instead of physical
Posted by GitBox <gi...@apache.org>.
mayursrivastava commented on issue #2484:
URL: https://github.com/apache/iceberg/issues/2484#issuecomment-909338948
@nastra I left 2 comments in the pr. Thanks for adding the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mayursrivastava commented on issue #2484: Fix ArrowReader to return Arrow vectors with logical Iceberg data type instead of physical
Posted by GitBox <gi...@apache.org>.
mayursrivastava commented on issue #2484:
URL: https://github.com/apache/iceberg/issues/2484#issuecomment-905545720
Thanks @nastra, please add me as a reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mayursrivastava commented on issue #2484: Fix ArrowReader to return Arrow vectors with logical Iceberg data type instead of physical
Posted by GitBox <gi...@apache.org>.
mayursrivastava commented on issue #2484:
URL: https://github.com/apache/iceberg/issues/2484#issuecomment-909338948
@nastra I left 2 comments in the pr. Thanks for adding the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on issue #2484: Fix ArrowReader to return Arrow vectors with logical Iceberg data type instead of physical
Posted by GitBox <gi...@apache.org>.
nastra commented on issue #2484:
URL: https://github.com/apache/iceberg/issues/2484#issuecomment-905528965
addressed this in https://github.com/apache/iceberg/pull/3024. @mayursrivastava would you like to review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org