You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bhuvaneswaran A <bh...@collab.net> on 2009/10/14 09:22:30 UTC

[PATCH] wc-ng: use TEMPORARY tables ...

Hello,
As discussed in this email thread [1], please find attached the patch to
use the TEMPORARY table when we want to remove columns from wc-ng
related tables, and reduce number of SQLs by not creating the TEMPORARY
tables explicitly.

[[
Use "CREATE TEMPORARY TABLE table_name AS SELECT" sql syntax to create
temporary table, while dropping columns from the original table.

* subversion/libsvn_wc/wc-metadata.sql
  (ACTUAL_NODE_BACKUP): Define as temporary table. Use "CREATE TEMPORARY
  TABLE table_name AS SELECT" syntax, instead of creating the table 
  explicitly.
  (BASE_NODE_BACKUP): Use "CREATE TEMPORARY TABLE table_name AS SELECT" 
  syntax, instead of creating the table explicitly.
]]

[1]
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405630

-- 
Bhuvaneswaran A    
CollabNet Software P Ltd.  |  www.collab.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407463

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
These times seem reasonable.  I just didn't understand why there seemed
to be far more "ping" emails than issues filed.  I guess the patches in
the difference have been applied :-).

Thanks for clarifying,

Daniel

Gavin 'Beau' Baumanis wrote on Fri, 30 Oct 2009 at 14:34 +1100:
> Hi Daniel,
> 
> What I have been doing is pinging the list after (about) a week of no
> comments.
> Then if another week passes after the ping - I then file it in the bug tracker
> and update the thread appropriately.
> 
> Please, feel free to provide alternate timings if you feel mine require a
> tweak!
> 
> Gavin.
> 
> 
> On 30/10/2009, at 13:59 , Daniel Shahaf wrote:
> 
> > Gavin Baumanis wrote on Fri, 30 Oct 2009 at 11:33 +1100:
> > > Ping. This patch submission has received no further comments.
> > 
> > Gavin, are you filing issues for patch submissions that don't get
> > comments even after you ping them?  I found only three in the tracker:
> > 
> > http://subversion.tigris.org/issues/buglist.cgi?issue_type=PATCH&email1=gavinbaumanis&emailtype1=exact&emailreporter1=1&Submit+query=Submit+query
> > 
> > Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2412915

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Daniel,

What I have been doing is pinging the list after (about) a week of no  
comments.
Then if another week passes after the ping - I then file it in the bug  
tracker and update the thread appropriately.

Please, feel free to provide alternate timings if you feel mine  
require a tweak!

Gavin.


On 30/10/2009, at 13:59 , Daniel Shahaf wrote:

> Gavin Baumanis wrote on Fri, 30 Oct 2009 at 11:33 +1100:
>> Ping. This patch submission has received no further comments.
>
> Gavin, are you filing issues for patch submissions that don't get
> comments even after you ping them?  I found only three in the tracker:
>
> http://subversion.tigris.org/issues/buglist.cgi?issue_type=PATCH&email1=gavinbaumanis&emailtype1=exact&emailreporter1=1&Submit+query=Submit+query
>
> Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2412911

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Gavin Baumanis wrote on Fri, 30 Oct 2009 at 11:33 +1100:
> Ping. This patch submission has received no further comments.

Gavin, are you filing issues for patch submissions that don't get
comments even after you ping them?  I found only three in the tracker:

http://subversion.tigris.org/issues/buglist.cgi?issue_type=PATCH&email1=gavinbaumanis&emailtype1=exact&emailreporter1=1&Submit+query=Submit+query

Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2412898

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping. This patch submission has received no further comments.

Gavin.


On 23/10/2009, at 05:43 , Bhuvaneswaran A wrote:

> Greg/Hyrum: ping?
>
> On Wed, 2009-10-14 at 14:52 +0530, Bhuvaneswaran A wrote:
>> Hello,
>> As discussed in this email thread [1], please find attached the  
>> patch to
>> use the TEMPORARY table when we want to remove columns from wc-ng
>> related tables, and reduce number of SQLs by not creating the  
>> TEMPORARY
>> tables explicitly.
>>
>> [[
>> Use "CREATE TEMPORARY TABLE table_name AS SELECT" sql syntax to  
>> create
>> temporary table, while dropping columns from the original table.
>>
>> * subversion/libsvn_wc/wc-metadata.sql
>> (ACTUAL_NODE_BACKUP): Define as temporary table. Use "CREATE  
>> TEMPORARY
>> TABLE table_name AS SELECT" syntax, instead of creating the table
>> explicitly.
>> (BASE_NODE_BACKUP): Use "CREATE TEMPORARY TABLE table_name AS SELECT"
>> syntax, instead of creating the table explicitly.
>> ]]
>>
>> [1]
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405630
>>
>> -- 
>> Bhuvaneswaran A
>> CollabNet Software P Ltd.  |  www.collab.net
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407463
> -- 
> Bhuvaneswaran A
> CollabNet Software P Ltd.  |  www.collab.net
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410355

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2412869

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Gavin Baumanis <ga...@thespidernet.com>.
I have logged issue ; 3527
http://subversion.tigris.org/issues/show_bug.cgi?id=3527

Gavin.

On 07/11/2009, at 20:03 , Gavin Baumanis wrote:

> Ping. This patch submission has received no comments.
> 
> Gavin.
> 
> 
> 
> On 23/10/2009, at 05:43 , Bhuvaneswaran A wrote:
> 
>> Greg/Hyrum: ping?
>> 
>> On Wed, 2009-10-14 at 14:52 +0530, Bhuvaneswaran A wrote:
>>> Hello,
>>> As discussed in this email thread [1], please find attached the  
>>> patch to
>>> use the TEMPORARY table when we want to remove columns from wc-ng
>>> related tables, and reduce number of SQLs by not creating the  
>>> TEMPORARY
>>> tables explicitly.
>>> 
>>> [[
>>> Use "CREATE TEMPORARY TABLE table_name AS SELECT" sql syntax to  
>>> create
>>> temporary table, while dropping columns from the original table.
>>> 
>>> * subversion/libsvn_wc/wc-metadata.sql
>>> (ACTUAL_NODE_BACKUP): Define as temporary table. Use "CREATE  
>>> TEMPORARY
>>> TABLE table_name AS SELECT" syntax, instead of creating the table
>>> explicitly.
>>> (BASE_NODE_BACKUP): Use "CREATE TEMPORARY TABLE table_name AS  
>>> SELECT"
>>> syntax, instead of creating the table explicitly.
>>> ]]
>>> 
>>> [1]
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405630
>>> 
>>> -- 
>>> Bhuvaneswaran A
>>> CollabNet Software P Ltd.  |  www.collab.net
>>> 
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407463
>> -- 
>> Bhuvaneswaran A
>> CollabNet Software P Ltd.  |  www.collab.net
>> 
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410355
> 
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415365

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2417824

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping. This patch submission has received no comments.

Gavin.



On 23/10/2009, at 05:43 , Bhuvaneswaran A wrote:

> Greg/Hyrum: ping?
>
> On Wed, 2009-10-14 at 14:52 +0530, Bhuvaneswaran A wrote:
>> Hello,
>> As discussed in this email thread [1], please find attached the  
>> patch to
>> use the TEMPORARY table when we want to remove columns from wc-ng
>> related tables, and reduce number of SQLs by not creating the  
>> TEMPORARY
>> tables explicitly.
>>
>> [[
>> Use "CREATE TEMPORARY TABLE table_name AS SELECT" sql syntax to  
>> create
>> temporary table, while dropping columns from the original table.
>>
>> * subversion/libsvn_wc/wc-metadata.sql
>>  (ACTUAL_NODE_BACKUP): Define as temporary table. Use "CREATE  
>> TEMPORARY
>>  TABLE table_name AS SELECT" syntax, instead of creating the table
>>  explicitly.
>>  (BASE_NODE_BACKUP): Use "CREATE TEMPORARY TABLE table_name AS  
>> SELECT"
>>  syntax, instead of creating the table explicitly.
>> ]]
>>
>> [1]
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405630
>>
>> -- 
>> Bhuvaneswaran A
>> CollabNet Software P Ltd.  |  www.collab.net
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407463
> -- 
> Bhuvaneswaran A
> CollabNet Software P Ltd.  |  www.collab.net
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410355

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415365

Re: [PATCH] wc-ng: use TEMPORARY tables ...

Posted by Bhuvaneswaran A <bh...@collab.net>.
Greg/Hyrum: ping?

On Wed, 2009-10-14 at 14:52 +0530, Bhuvaneswaran A wrote:
> Hello,
> As discussed in this email thread [1], please find attached the patch to
> use the TEMPORARY table when we want to remove columns from wc-ng
> related tables, and reduce number of SQLs by not creating the TEMPORARY
> tables explicitly.
> 
> [[
> Use "CREATE TEMPORARY TABLE table_name AS SELECT" sql syntax to create
> temporary table, while dropping columns from the original table.
> 
> * subversion/libsvn_wc/wc-metadata.sql
>   (ACTUAL_NODE_BACKUP): Define as temporary table. Use "CREATE TEMPORARY
>   TABLE table_name AS SELECT" syntax, instead of creating the table 
>   explicitly.
>   (BASE_NODE_BACKUP): Use "CREATE TEMPORARY TABLE table_name AS SELECT" 
>   syntax, instead of creating the table explicitly.
> ]]
> 
> [1]
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405630
> 
> -- 
> Bhuvaneswaran A    
> CollabNet Software P Ltd.  |  www.collab.net
> 
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407463
-- 
Bhuvaneswaran A    
CollabNet Software P Ltd.  |  www.collab.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410355