You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by dmabry <gi...@git.apache.org> on 2015/10/22 17:24:05 UTC
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/966
Added support for KVM teamd devices to LibvirtComputingResource.java
This will allow KVM users to utilize teamd nic teaming devices named team*.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmabry/cloudstack feature_support_nic_teaming
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #966
----
commit e1a401c0232928109330cc4670e54b6a80a97de4
Author: David Mabry <dm...@ena.com>
Date: 2015-10-22T15:19:50Z
Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150553318
Agreed with @remibergsma, but the code-wise this is a LGTM.
One PR which includes #812 as well would be nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150588016
@DaanHoogland Sounds good. I'll hold off. Thanks for the help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150546240
See also PR #812 and the comments there. Can anyone combine the two and address the comments in PR #812 please? If it can be done soon, we can merge it in 4.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150585840
@dmabry I am already writng a combination. please review when done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150582452
I'll take a look at #812 and see about combining them into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---