You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/06 19:57:20 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #5926: API: Simplify the ManifestEvaluator

rdblue commented on code in PR #5926:
URL: https://github.com/apache/iceberg/pull/5926#discussion_r989431779


##########
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java:
##########
@@ -399,18 +406,5 @@ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
 
       return ROWS_MIGHT_MATCH;
     }
-
-    private boolean allValuesAreNull(PartitionFieldSummary summary, Type.TypeID typeId) {

Review Comment:
   I think I'd still prefer to keep this as a separate function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org