You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/07/23 00:12:37 UTC
Re: svn commit: rev 6536 - trunk/tools/cvs2svn
On Tue, Jul 22, 2003 at 03:19:14PM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: Tue Jul 22 15:19:13 2003
> New Revision: 6536
>
> Modified:
> trunk/tools/cvs2svn/cvs2svn.py
> Log:
> Fix issue #1416: failing to parse binary RCS files on Windows.
>
> * tools/cvs2svn/cvs2svn.py
> (visit_file, RevInfoParser.parse_cvs_file): Open in binary mode.
> (Dumper.add_or_change_path): Don't pass a buffer size to os.popen;
> there's no need to optimize for the svn filesystem anymore, and on
> Windows os.popen doesn't take that argument.
Wasn't this a patch from a contributor? e.g. recognition in the log msg?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 6536 - trunk/tools/cvs2svn
Posted by kf...@collab.net.
cmpilato@collab.net writes:
> > Wasn't this a patch from a contributor? e.g. recognition in the log msg?
No (but thanks for checking).
> Hey, wait a second! This solution was actually suggested to Karl by
> me -- I even typed the changes on the Windows 98 box -- and *I* didn't
> even get credit! Foul! Foul! :-)
>
> Love, a not-really-caring C-Mike
Whups! I fixed the log msg anyway, so there :-).
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 6536 - trunk/tools/cvs2svn
Posted by cm...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> On Tue, Jul 22, 2003 at 03:19:14PM -0500, kfogel@tigris.org wrote:
> > Author: kfogel
> > Date: Tue Jul 22 15:19:13 2003
> > New Revision: 6536
> >
> > Modified:
> > trunk/tools/cvs2svn/cvs2svn.py
> > Log:
> > Fix issue #1416: failing to parse binary RCS files on Windows.
> >
> > * tools/cvs2svn/cvs2svn.py
> > (visit_file, RevInfoParser.parse_cvs_file): Open in binary mode.
> > (Dumper.add_or_change_path): Don't pass a buffer size to os.popen;
> > there's no need to optimize for the svn filesystem anymore, and on
> > Windows os.popen doesn't take that argument.
>
> Wasn't this a patch from a contributor? e.g. recognition in the log msg?
If there was a patch, we didn't use it.
Hey, wait a second! This solution was actually suggested to Karl by
me -- I even typed the changes on the Windows 98 box -- and *I* didn't
even get credit! Foul! Foul! :-)
Love, a not-really-caring C-Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org