You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/29 00:22:33 UTC
[GitHub] [ignite] isapego opened a new pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
isapego opened a new pull request #8726:
URL: https://github.com/apache/ignite/pull/8726
Added `connectionsLimit` configuration parameter to C++ thin client, that can be used to limit number of active connections that client establishes with cluser.
Also added test, that parses nodes logs to check that connections were actually established.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a change in pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #8726:
URL: https://github.com/apache/ignite/pull/8726#discussion_r566761916
##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
return partitionAwareness;
}
+ /**
+ * Get connection limit.
+ * Zero means that number of active connections is not limited.
Review comment:
But it is unsigned. If you set -1 compiler will give you either a warning or error depending on your compiler flags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a change in pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #8726:
URL: https://github.com/apache/ignite/pull/8726#discussion_r566762964
##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
return partitionAwareness;
}
+ /**
+ * Get connection limit.
Review comment:
Actually, it does so with partition awareness disabled as well. It was done for fast failover and load balancing. But I've got your point, will add a more detailed description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #8726:
URL: https://github.com/apache/ignite/pull/8726#discussion_r566764772
##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
return partitionAwareness;
}
+ /**
+ * Get connection limit.
+ * Zero means that number of active connections is not limited.
Review comment:
Oops, did not pay attention to the type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #8726:
URL: https://github.com/apache/ignite/pull/8726#discussion_r566752478
##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
return partitionAwareness;
}
+ /**
+ * Get connection limit.
+ * Zero means that number of active connections is not limited.
Review comment:
What if I set `-1`?
##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
return partitionAwareness;
}
+ /**
+ * Get connection limit.
Review comment:
Let's explain in more detail, something like `with Partition Awareness enabled, thin client establishes a connection to every server node in the cluster. Use this setting to limit the number of active connections. This reduces the resource usage, but can have a negative effect on cache operation performance`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8726: IGNITE-13763: Add connection limit for C++ thin client
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8726:
URL: https://github.com/apache/ignite/pull/8726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org