You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/03/22 14:30:45 UTC

[GitHub] [thrift] afs commented on a change in pull request #1866: THRIFT-4949 improve HTTP/1 server test case

afs commented on a change in pull request #1866:
URL: https://github.com/apache/thrift/pull/1866#discussion_r598767273



##########
File path: lib/java/gradle/environment.gradle
##########
@@ -66,7 +67,8 @@ dependencies {
     compile "org.slf4j:slf4j-api:${slf4jVersion}"
     compile "org.apache.httpcomponents:httpclient:${httpclientVersion}"
     compile "org.apache.httpcomponents:httpcore:${httpcoreVersion}"
-    compile "javax.servlet:servlet-api:${servletVersion}"
+    //compile "javax.servlet:servlet-api:${servletVersion}"
+    compile "org.apache.tomcat.embed:tomcat-embed-core:${tomcatEmbedVersion}"

Review comment:
       Was "testCompile" meant here? As is, this becomes a dependency downstream.
   
   [THRIFT-5375](https://issues.apache.org/jira/browse/THRIFT-5375). 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org