Re: [PR] fix(cache): warm native dashboard filter defaults [superset]

["bito-code-review[bot] (via GitHub)" <gi...@apache.org>]

bito-code-review[bot] commented on PR #43073:
URL: https://github.com/apache/superset/pull/43073#issuecomment-5267175265

   <!-- Bito Reply -->
   The flagged issue is correct. In `superset/commands/chart/warm_up_cache.py`, the change from `extend` to list concatenation (`+`) prepends dashboard filters to the existing `query.filter` list. This causes dashboard filters to be applied alongside explicit filters rather than replacing them, which can lead to conflicts if both sets of filters target the same column.
   
   To resolve this, you should ensure that explicit filters take precedence. One approach is to filter out any dashboard-derived filters that conflict with the explicit filters before merging, or to maintain the previous behavior where explicit filters are treated as authoritative.
   
   Would you like me to implement a fix for this issue? I can also check the rest of the PR for other comments if you would like.
   
   **superset/commands/chart/warm_up_cache.py**
   ```
   # Example of preserving precedence
                   existing_cols = {f.get("col") for f in query.filter}
                   filtered_dashboard_filters = [
                       f for f in dashboard_filters if f.get("col") not in existing_cols
                   ]
                   query.filter.extend(filtered_dashboard_filters)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org