You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2025/09/29 03:13:29 UTC
[PR] Extract AbstractRecordSingleTableInventoryCalculator [shardingsphere]
sandynz opened a new pull request, #36746:
URL: https://github.com/apache/shardingsphere/pull/36746
Changes proposed in this pull request:
- Extract AbstractRecordSingleTableInventoryCalculator
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extract AbstractRecordSingleTableInventoryCalculator [shardingsphere]
Posted by "mkansara23 (via GitHub)" <gi...@apache.org>.
mkansara23 commented on PR #36746:
URL: https://github.com/apache/shardingsphere/pull/36746#issuecomment-3347924851
Hi @sandynz ,
I noticed 36 rename refactoring in your [recent commit](https://github.com/apache/shardingsphere/commit/fe989e2981ec209fea307a12c5e275edd0214418):
- Single Variable Declaration rawRecord -> record.
- Type Declaration RecordSingleTableInventoryCalculatorTest -> RecordSingleTableInventoryCheckCalculatorTest.
- Single Variable Declaration records -> record.
- Variable Declaration Statement firstUniqueKey -> maxUniqueKeyValue.
- Type Declaration RecordSingleTableInventoryCalculator -> RecordSingleTableInventoryCheckCalculator.
- Method Declaration convertRecordsToResult -> getFirstUniqueKeyValue.
How did you identify that these 36 elements were connected and should be renamed together?
- Did you find this task challenging in any way?
- Did you perform the renames manually or with tools?
- Would it be helpful if tools could detect and rename connected program elements together instead of one by one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extract AbstractRecordSingleTableInventoryCalculator [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #36746:
URL: https://github.com/apache/shardingsphere/pull/36746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org