You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/24 00:02:47 UTC
[kudu-CR] java: fix CapturingToFileLogAppender
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13418
to review the following change.
Change subject: java: fix CapturingToFileLogAppender
......................................................................
java: fix CapturingToFileLogAppender
It was broken in commit 0114ce1d0: the try-with-resources in the constructor
closed the OutputStream out from under the BufferedWriter.
I added a regression test for this.
Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
3 files changed, 174 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/13418/1
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] java: fix CapturingToFileLogAppender
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13418 )
Change subject: java: fix CapturingToFileLogAppender
......................................................................
Patch Set 2:
> Patch Set 1: Code-Review+2
>
> (1 comment)
Whoops, I merged this patch by mistake instead of the other one.
I'll address your feedback (and Grant's, if he has any) in a follow-up.
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 04:35:02 +0000
Gerrit-HasComments: No
[kudu-CR] java: fix CapturingToFileLogAppender
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13418 )
Change subject: java: fix CapturingToFileLogAppender
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] java: fix CapturingToFileLogAppender
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13418 )
Change subject: java: fix CapturingToFileLogAppender
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13418/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java:
http://gerrit.cloudera.org:8080/#/c/13418/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java@139
PS1, Line 139:
nit: remove.
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 00:26:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] java: fix CapturingToFileLogAppender
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13418 )
Change subject: java: fix CapturingToFileLogAppender
......................................................................
java: fix CapturingToFileLogAppender
It was broken in commit 0114ce1d0: the try-with-resources in the constructor
closed the OutputStream out from under the BufferedWriter.
I added a regression test for this.
Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Reviewed-on: http://gerrit.cloudera.org:8080/13418
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
A java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
3 files changed, 174 insertions(+), 8 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] java: fix CapturingToFileLogAppender
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13418 )
Change subject: java: fix CapturingToFileLogAppender
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, known flake in TestAuthTokenReacquire.
--
To view, visit http://gerrit.cloudera.org:8080/13418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa14df5cd4025236ec398acf4973520d9dea082
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 04:33:04 +0000
Gerrit-HasComments: No