[GitHub] [druid] gianm commented on a diff in pull request #12715: Allow adding calcite rules from extensions

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12715:
URL: https://github.com/apache/druid/pull/12715#discussion_r912237938


##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/Rules.java:
##########
@@ -234,7 +242,11 @@ private static Program buildHepProgram(Iterable<? extends RelOptRule> rules,
     return Programs.of(builder.build(), noDag, metadataProvider);
   }
 
-  private static List<RelOptRule> druidConventionRuleSet(final PlannerContext plannerContext)
+  @VisibleForTesting

Review Comment:
   Counterpoint: I like the annotation. Its meaning is very clear: "this method is not intended to be part of the public API of the class; it's only marked as `public` (or package-private, or whatever) so it can be unit-tested". There's no need to provide context about why it's a bad idea. It's up to the person that later on wants to use it to determine why it's a good idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org