You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2017/12/13 00:12:56 UTC
[trafficserver] branch master updated (03d110c -> c802ea2)
This is an automated email from the ASF dual-hosted git repository.
masaori pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.
from 03d110c Rename HttpSM::ua_session HttpSM::ua_txn
new 9adddd6 Revert "Cancel closing if Http2SendDataFrameResult is NO_WINDOW"
new c802ea2 Increase write_vio.ndone only if sending DATA frame is succeeded
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
proxy/http2/Http2ConnectionState.cc | 20 +++++++++++++------
proxy/http2/Http2ConnectionState.h | 11 ++++++-----
proxy/http2/Http2Stream.cc | 39 +++++++++++++++++++------------------
proxy/http2/Http2Stream.h | 1 +
tests/gold_tests/h2/http2.test.py | 3 ++-
5 files changed, 43 insertions(+), 31 deletions(-)
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].
[trafficserver] 01/02: Revert "Cancel closing if
Http2SendDataFrameResult is NO_WINDOW"
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
masaori pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 9adddd6096cc213225e7ee20778645aa0b0d24ba
Author: Masaori Koshiba <ma...@apache.org>
AuthorDate: Mon Nov 27 09:10:52 2017 +0900
Revert "Cancel closing if Http2SendDataFrameResult is NO_WINDOW"
This reverts commit 9a93d32863364e01267b5aabd322a9740c695441.
---
proxy/http2/Http2ConnectionState.cc | 38 +++++++++++++++++++------------------
proxy/http2/Http2ConnectionState.h | 14 +++++++-------
proxy/http2/Http2Stream.cc | 22 ++++++++-------------
3 files changed, 35 insertions(+), 39 deletions(-)
diff --git a/proxy/http2/Http2ConnectionState.cc b/proxy/http2/Http2ConnectionState.cc
index 6d76e2d..26fa97b 100644
--- a/proxy/http2/Http2ConnectionState.cc
+++ b/proxy/http2/Http2ConnectionState.cc
@@ -1236,11 +1236,11 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
ink_release_assert(stream != nullptr);
Http2StreamDebug(ua_session, stream->get_id(), "top node, point=%d", node->point);
- size_t len = 0;
- Http2SendDataFrameResult result = send_a_data_frame(stream, len);
+ size_t len = 0;
+ Http2SendADataFrameResult result = send_a_data_frame(stream, len);
switch (result) {
- case Http2SendDataFrameResult::NO_ERROR: {
+ case HTTP2_SEND_A_DATA_FRAME_NO_ERROR: {
// No response body to send
if (len == 0 && !stream->is_body_done()) {
dependency_tree->deactivate(node, len);
@@ -1249,7 +1249,7 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
}
break;
}
- case Http2SendDataFrameResult::DONE: {
+ case HTTP2_SEND_A_DATA_FRAME_DONE: {
dependency_tree->deactivate(node, len);
delete_stream(stream);
break;
@@ -1264,7 +1264,7 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
return;
}
-Http2SendDataFrameResult
+Http2SendADataFrameResult
Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_length)
{
const ssize_t window_size = std::min(this->client_rwnd, stream->client_rwnd);
@@ -1286,7 +1286,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
if (read_available_size > 0) {
// We only need to check for window size when there is a payload
if (window_size <= 0) {
- return Http2SendDataFrameResult::NO_WINDOW;
+ return HTTP2_SEND_A_DATA_FRAME_NO_WINDOW;
}
// Copy into the payload buffer. Seems like we should be able to skip this copy step
payload_length = current_reader->read(payload_buffer, write_available_size);
@@ -1298,7 +1298,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
// If we return here, we never send the END_STREAM in the case of a early terminating OS.
// OK if there is no body yet. Otherwise continue on to send a DATA frame and delete the stream
if (!stream->is_body_done() && payload_length == 0) {
- return Http2SendDataFrameResult::NO_PAYLOAD;
+ return HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD;
}
if (stream->is_body_done() && read_available_size <= write_available_size) {
@@ -1330,13 +1330,13 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
// Setting to the same state shouldn't be erroneous
stream->change_state(data.header().type, data.header().flags);
- return Http2SendDataFrameResult::DONE;
+ return HTTP2_SEND_A_DATA_FRAME_DONE;
}
- return Http2SendDataFrameResult::NO_ERROR;
+ return HTTP2_SEND_A_DATA_FRAME_NO_ERROR;
}
-Http2SendDataFrameResult
+void
Http2ConnectionState::send_data_frames(Http2Stream *stream)
{
// To follow RFC 7540 must not send more frames other than priority on
@@ -1345,25 +1345,27 @@ Http2ConnectionState::send_data_frames(Http2Stream *stream)
stream->get_state() == Http2StreamState::HTTP2_STREAM_STATE_CLOSED) {
Http2StreamDebug(this->ua_session, stream->get_id(), "Shutdown half closed local stream");
this->delete_stream(stream);
- return Http2SendDataFrameResult::NO_ERROR;
+ return;
}
- size_t len = 0;
- Http2SendDataFrameResult result = Http2SendDataFrameResult::NO_ERROR;
- while (result == Http2SendDataFrameResult::NO_ERROR) {
- result = send_a_data_frame(stream, len);
+ size_t len = 0;
+ while (true) {
+ Http2SendADataFrameResult result = send_a_data_frame(stream, len);
- if (result == Http2SendDataFrameResult::DONE) {
+ if (result == HTTP2_SEND_A_DATA_FRAME_DONE) {
// Delete a stream immediately
// TODO its should not be deleted for a several time to handling
// RST_STREAM and WINDOW_UPDATE.
// See 'closed' state written at [RFC 7540] 5.1.
Http2StreamDebug(this->ua_session, stream->get_id(), "Shutdown stream");
this->delete_stream(stream);
+ break;
+ } else if (result == HTTP2_SEND_A_DATA_FRAME_NO_ERROR) {
+ continue;
+ } else {
+ break;
}
}
-
- return result;
}
void
diff --git a/proxy/http2/Http2ConnectionState.h b/proxy/http2/Http2ConnectionState.h
index 1a640b0..a4ffd76 100644
--- a/proxy/http2/Http2ConnectionState.h
+++ b/proxy/http2/Http2ConnectionState.h
@@ -31,11 +31,11 @@
class Http2ClientSession;
-enum class Http2SendDataFrameResult {
- NO_ERROR = 0,
- NO_WINDOW = 1,
- NO_PAYLOAD = 2,
- DONE = 3,
+enum Http2SendADataFrameResult {
+ HTTP2_SEND_A_DATA_FRAME_NO_ERROR = 0,
+ HTTP2_SEND_A_DATA_FRAME_NO_WINDOW = 1,
+ HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD = 2,
+ HTTP2_SEND_A_DATA_FRAME_DONE = 3,
};
enum Http2ShutdownState { NOT_INITIATED, INITIATED, IN_PROGRESS };
@@ -218,8 +218,8 @@ public:
// HTTP/2 frame sender
void schedule_stream(Http2Stream *stream);
void send_data_frames_depends_on_priority();
- Http2SendDataFrameResult send_data_frames(Http2Stream *stream);
- Http2SendDataFrameResult send_a_data_frame(Http2Stream *stream, size_t &payload_length);
+ void send_data_frames(Http2Stream *stream);
+ Http2SendADataFrameResult send_a_data_frame(Http2Stream *stream, size_t &payload_length);
void send_headers_frame(Http2Stream *stream);
void send_push_promise_frame(Http2Stream *stream, URL &url, const MIMEField *accept_encoding);
void send_rst_stream_frame(Http2StreamId id, Http2ErrorCode ec);
diff --git a/proxy/http2/Http2Stream.cc b/proxy/http2/Http2Stream.cc
index 6c08ec5..88d7ac1 100644
--- a/proxy/http2/Http2Stream.cc
+++ b/proxy/http2/Http2Stream.cc
@@ -317,32 +317,26 @@ void
Http2Stream::do_io_close(int /* flags */)
{
SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
-
+ super::release(nullptr);
if (!closed) {
- if (parent && this->is_client_state_writeable()) {
- // Make sure any trailing end of stream frames are sent
- // Wee will be removed at send_data_frames or closing connection phase
- Http2SendDataFrameResult result = static_cast<Http2ClientSession *>(parent)->connection_state.send_data_frames(this);
- if (result == Http2SendDataFrameResult::NO_WINDOW) {
- Http2StreamDebug("cancel closing");
- return;
- } else {
- Http2StreamDebug("continue closing");
- }
- }
+ Http2StreamDebug("do_io_close");
// When we get here, the SM has initiated the shutdown. Either it received a WRITE_COMPLETE, or it is shutting down. Any
// remaining IO operations back to client should be abandoned. The SM-side buffers backing these operations will be deleted
// by the time this is called from transaction_done.
closed = true;
+ if (parent && this->is_client_state_writeable()) {
+ // Make sure any trailing end of stream frames are sent
+ // Wee will be removed at send_data_frames or closing connection phase
+ static_cast<Http2ClientSession *>(parent)->connection_state.send_data_frames(this);
+ }
+
clear_timers();
clear_io_events();
// Wait until transaction_done is called from HttpSM to signal that the TXN_CLOSE hook has been executed
}
-
- super::release(nullptr);
}
/*
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.
[trafficserver] 02/02: Increase write_vio.ndone only if sending
DATA frame is succeeded
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
masaori pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit c802ea2f95af2360520fc75d57266586271e0196
Author: Masaori Koshiba <ma...@apache.org>
AuthorDate: Mon Nov 27 13:59:53 2017 +0900
Increase write_vio.ndone only if sending DATA frame is succeeded
---
proxy/http2/Http2ConnectionState.cc | 48 +++++++++++++++++++++----------------
proxy/http2/Http2ConnectionState.h | 13 +++++-----
proxy/http2/Http2Stream.cc | 19 ++++++++++-----
proxy/http2/Http2Stream.h | 1 +
tests/gold_tests/h2/http2.test.py | 3 ++-
5 files changed, 50 insertions(+), 34 deletions(-)
diff --git a/proxy/http2/Http2ConnectionState.cc b/proxy/http2/Http2ConnectionState.cc
index 26fa97b..bab5b15 100644
--- a/proxy/http2/Http2ConnectionState.cc
+++ b/proxy/http2/Http2ConnectionState.cc
@@ -1236,11 +1236,11 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
ink_release_assert(stream != nullptr);
Http2StreamDebug(ua_session, stream->get_id(), "top node, point=%d", node->point);
- size_t len = 0;
- Http2SendADataFrameResult result = send_a_data_frame(stream, len);
+ size_t len = 0;
+ Http2SendDataFrameResult result = send_a_data_frame(stream, len);
switch (result) {
- case HTTP2_SEND_A_DATA_FRAME_NO_ERROR: {
+ case Http2SendDataFrameResult::NO_ERROR: {
// No response body to send
if (len == 0 && !stream->is_body_done()) {
dependency_tree->deactivate(node, len);
@@ -1249,7 +1249,7 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
}
break;
}
- case HTTP2_SEND_A_DATA_FRAME_DONE: {
+ case Http2SendDataFrameResult::DONE: {
dependency_tree->deactivate(node, len);
delete_stream(stream);
break;
@@ -1264,13 +1264,14 @@ Http2ConnectionState::send_data_frames_depends_on_priority()
return;
}
-Http2SendADataFrameResult
+Http2SendDataFrameResult
Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_length)
{
const ssize_t window_size = std::min(this->client_rwnd, stream->client_rwnd);
const size_t buf_len = BUFFER_SIZE_FOR_INDEX(buffer_size_index[HTTP2_FRAME_TYPE_DATA]);
const size_t write_available_size = std::min(buf_len, static_cast<size_t>(window_size));
size_t read_available_size = 0;
+ payload_length = 0;
uint8_t flags = 0x00;
uint8_t payload_buffer[buf_len];
@@ -1280,16 +1281,21 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
if (current_reader) {
read_available_size = static_cast<size_t>(current_reader->read_avail());
+ } else {
+ Http2StreamDebug(this->ua_session, stream->get_id(), "couldn't get data reader");
+ return Http2SendDataFrameResult::ERROR;
}
// Select appropriate payload length
if (read_available_size > 0) {
// We only need to check for window size when there is a payload
if (window_size <= 0) {
- return HTTP2_SEND_A_DATA_FRAME_NO_WINDOW;
+ Http2StreamDebug(this->ua_session, stream->get_id(), "No window");
+ return Http2SendDataFrameResult::NO_WINDOW;
}
// Copy into the payload buffer. Seems like we should be able to skip this copy step
- payload_length = current_reader->read(payload_buffer, write_available_size);
+ payload_length = std::min(read_available_size, write_available_size);
+ current_reader->memcpy(payload_buffer, static_cast<int64_t>(payload_length));
} else {
payload_length = 0;
}
@@ -1298,7 +1304,8 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
// If we return here, we never send the END_STREAM in the case of a early terminating OS.
// OK if there is no body yet. Otherwise continue on to send a DATA frame and delete the stream
if (!stream->is_body_done() && payload_length == 0) {
- return HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD;
+ Http2StreamDebug(this->ua_session, stream->get_id(), "No payload");
+ return Http2SendDataFrameResult::NO_PAYLOAD;
}
if (stream->is_body_done() && read_available_size <= write_available_size) {
@@ -1310,8 +1317,8 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
stream->client_rwnd -= payload_length;
// Create frame
- Http2StreamDebug(ua_session, stream->get_id(), "Send a DATA frame - client window con: %zd stream: %zd payload: %zd", client_rwnd,
- stream->client_rwnd, payload_length);
+ Http2StreamDebug(ua_session, stream->get_id(), "Send a DATA frame - client window con: %5zd stream: %5zd payload: %5zd",
+ client_rwnd, stream->client_rwnd, payload_length);
Http2Frame data(HTTP2_FRAME_TYPE_DATA, stream->get_id(), flags);
data.alloc(buffer_size_index[HTTP2_FRAME_TYPE_DATA]);
@@ -1319,6 +1326,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
data.finalize(payload_length);
stream->update_sent_count(payload_length);
+ current_reader->consume(payload_length);
// xmit event
SCOPED_MUTEX_LOCK(lock, this->ua_session->mutex, this_ethread());
@@ -1330,10 +1338,10 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
// Setting to the same state shouldn't be erroneous
stream->change_state(data.header().type, data.header().flags);
- return HTTP2_SEND_A_DATA_FRAME_DONE;
+ return Http2SendDataFrameResult::DONE;
}
- return HTTP2_SEND_A_DATA_FRAME_NO_ERROR;
+ return Http2SendDataFrameResult::NO_ERROR;
}
void
@@ -1348,24 +1356,22 @@ Http2ConnectionState::send_data_frames(Http2Stream *stream)
return;
}
- size_t len = 0;
- while (true) {
- Http2SendADataFrameResult result = send_a_data_frame(stream, len);
+ size_t len = 0;
+ Http2SendDataFrameResult result = Http2SendDataFrameResult::NO_ERROR;
+ while (result == Http2SendDataFrameResult::NO_ERROR) {
+ result = send_a_data_frame(stream, len);
- if (result == HTTP2_SEND_A_DATA_FRAME_DONE) {
+ if (result == Http2SendDataFrameResult::DONE) {
// Delete a stream immediately
// TODO its should not be deleted for a several time to handling
// RST_STREAM and WINDOW_UPDATE.
// See 'closed' state written at [RFC 7540] 5.1.
Http2StreamDebug(this->ua_session, stream->get_id(), "Shutdown stream");
this->delete_stream(stream);
- break;
- } else if (result == HTTP2_SEND_A_DATA_FRAME_NO_ERROR) {
- continue;
- } else {
- break;
}
}
+
+ return;
}
void
diff --git a/proxy/http2/Http2ConnectionState.h b/proxy/http2/Http2ConnectionState.h
index a4ffd76..27f2dc4 100644
--- a/proxy/http2/Http2ConnectionState.h
+++ b/proxy/http2/Http2ConnectionState.h
@@ -31,11 +31,12 @@
class Http2ClientSession;
-enum Http2SendADataFrameResult {
- HTTP2_SEND_A_DATA_FRAME_NO_ERROR = 0,
- HTTP2_SEND_A_DATA_FRAME_NO_WINDOW = 1,
- HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD = 2,
- HTTP2_SEND_A_DATA_FRAME_DONE = 3,
+enum class Http2SendDataFrameResult {
+ NO_ERROR = 0,
+ NO_WINDOW,
+ NO_PAYLOAD,
+ ERROR,
+ DONE,
};
enum Http2ShutdownState { NOT_INITIATED, INITIATED, IN_PROGRESS };
@@ -219,7 +220,7 @@ public:
void schedule_stream(Http2Stream *stream);
void send_data_frames_depends_on_priority();
void send_data_frames(Http2Stream *stream);
- Http2SendADataFrameResult send_a_data_frame(Http2Stream *stream, size_t &payload_length);
+ Http2SendDataFrameResult send_a_data_frame(Http2Stream *stream, size_t &payload_length);
void send_headers_frame(Http2Stream *stream);
void send_push_promise_frame(Http2Stream *stream, URL &url, const MIMEField *accept_encoding);
void send_rst_stream_frame(Http2StreamId id, Http2ErrorCode ec);
diff --git a/proxy/http2/Http2Stream.cc b/proxy/http2/Http2Stream.cc
index 88d7ac1..d2d91c0 100644
--- a/proxy/http2/Http2Stream.cc
+++ b/proxy/http2/Http2Stream.cc
@@ -318,6 +318,7 @@ Http2Stream::do_io_close(int /* flags */)
{
SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
super::release(nullptr);
+
if (!closed) {
Http2StreamDebug("do_io_close");
@@ -535,8 +536,8 @@ Http2Stream::update_write_request(IOBufferReader *buf_reader, int64_t write_len,
// WRITE_COMPLETE event
SCOPED_MUTEX_LOCK(lock, write_vio.mutex, this_ethread());
int64_t total_added = 0;
- if (write_vio.nbytes > 0 && write_vio.ndone < write_vio.nbytes) {
- int64_t num_to_write = write_vio.nbytes - write_vio.ndone;
+ if (write_vio.nbytes > 0 && write_vio.ntodo() > 0) {
+ int64_t num_to_write = write_vio.ntodo();
if (num_to_write > write_len) {
num_to_write = write_len;
}
@@ -561,18 +562,25 @@ Http2Stream::update_write_request(IOBufferReader *buf_reader, int64_t write_len,
}
}
+ IOBufferReader *response_reader = this->response_get_data_reader();
+ int64_t response_buffer_size = response_reader->read_avail();
+ Http2StreamDebug("write_vio.nbytes=%" PRId64 ", write_vio.ndone=%" PRId64 ", buf_reader.read_avail=%" PRId64
+ ", total_added=%" PRId64 ", response_buffer=%" PRId64,
+ write_vio.nbytes, write_vio.ndone, buf_reader->read_avail(), total_added, response_buffer_size);
+
bool is_done = false;
this->response_process_data(is_done);
if (total_added > 0 || is_done) {
- write_vio.ndone += total_added;
- int send_event = (write_vio.nbytes == write_vio.ndone || is_done) ? VC_EVENT_WRITE_COMPLETE : VC_EVENT_WRITE_READY;
+ int send_event = (write_vio.ntodo() == response_buffer_size || is_done) ? VC_EVENT_WRITE_COMPLETE : VC_EVENT_WRITE_READY;
// Process the new data
if (!this->response_header_done) {
// Still parsing the response_header
int bytes_used = 0;
int state = this->response_header.parse_resp(&http_parser, this->response_reader, &bytes_used, false);
- // this->response_reader->consume(bytes_used);
+ // HTTPHdr::parse_resp() consumed the response_reader in above
+ write_vio.ndone += this->response_header.length_get();
+
switch (state) {
case PARSE_RESULT_DONE: {
this->response_header_done = true;
@@ -655,7 +663,6 @@ Http2Stream::send_response_body()
if (Http2::stream_priority_enabled) {
parent->connection_state.schedule_stream(this);
} else {
- // Send DATA frames directly
parent->connection_state.send_data_frames(this);
}
inactive_timeout_at = Thread::get_hrtime() + inactive_timeout;
diff --git a/proxy/http2/Http2Stream.h b/proxy/http2/Http2Stream.h
index 6405e87..34aec1f 100644
--- a/proxy/http2/Http2Stream.h
+++ b/proxy/http2/Http2Stream.h
@@ -81,6 +81,7 @@ public:
update_sent_count(unsigned num_bytes)
{
bytes_sent += num_bytes;
+ this->write_vio.ndone += num_bytes;
}
Http2StreamId
diff --git a/tests/gold_tests/h2/http2.test.py b/tests/gold_tests/h2/http2.test.py
index cbb5b1f..5fffac2 100644
--- a/tests/gold_tests/h2/http2.test.py
+++ b/tests/gold_tests/h2/http2.test.py
@@ -65,11 +65,12 @@ ts.Disk.ssl_multicert_config.AddLine(
)
ts.Disk.records_config.update({
'proxy.config.diags.debug.enabled': 1,
- 'proxy.config.diags.debug.tags': 'http|socket',
+ 'proxy.config.diags.debug.tags': 'http2',
'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.server.private_key.path': '{0}'.format(ts.Variables.SSLDir),
# enable ssl port
'proxy.config.http.server_ports': '{0} {1}:proto=http2;http:ssl'.format(ts.Variables.port, ts.Variables.ssl_port),
+ 'proxy.config.http.cache.http': 0,
'proxy.config.ssl.client.verify.server': 0,
'proxy.config.ssl.server.cipher_suite': 'ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:AES128-GCM-SHA256:AES256-GCM-SHA384:ECDHE-RSA-RC4-SHA:ECDHE-RSA-AES128-SHA:ECDHE-RSA-AES256-SHA:RC4-SHA:RC4-MD5:AES128-SHA:AES256-SHA:DES-CBC3-SHA!SRP:!DSS:!PSK:!aNULL:!eNULL:!SSLv2',
'proxy.config.http2.active_timeout_in': 3,
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.