[jira] Closed: (GERONIMO-3614) the executor in AsyncHttpClient is static, and may not be shut down properly

["Jeff Genender (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Genender closed GERONIMO-3614.
-----------------------------------

    Resolution: Fixed

Applied patch...thanks!

> the executor in AsyncHttpClient is static, and may not be shut down properly
> ----------------------------------------------------------------------------
>
>                 Key: GERONIMO-3614
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3614
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: AsyncHttpClient.patch
>
>
> The threadPool variable in AsyncHttpClient (that gets passed to Mina for I/O) is declared as static, and I believe it is a bug.  If you instantiate more than one AsyncHttpClient objects, subsequent instantiations overwrite the value of threadPool.
> It appears it is the responsibility of AsyncHttpClient, not the caller of AsyncHttpClient, to shut down the thread pool.  It means then, if you instantiated multiple AsyncHttpClient objects, and call destroyAll() on all of them, only the thread pool that is associated with the last AsyncHttpClient object will be properly shut down.  All previous thread pools will linger.
> The fix should be to turn it into an instance variable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.