You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2023/08/27 23:23:12 UTC
Re: [maven-build-cache-extension] branch master updated: remove unused logback dependency (#88)
-1 Please revert this commit.
I'm the only one to express some concerns about such change.
Se conversations here
https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694496822
On Sat, 26 Aug 2023 at 23:33, <el...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> elharo pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/maven-build-cache-extension.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 47f8404 remove unused logback dependency (#88)
> 47f8404 is described below
>
> commit 47f8404c256fa51ea2ce819eb782de88c36c2bd5
> Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
> AuthorDate: Sat Aug 26 09:31:34 2023 -0400
>
> remove unused logback dependency (#88)
> ---
> pom.xml | 6 ------
> src/test/resources/logback.xml | 40 ----------------------------------------
> 2 files changed, 46 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index 1c11381..8dc816c 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -188,12 +188,6 @@ under the License.
> <artifactId>junit-jupiter</artifactId>
> <scope>test</scope>
> </dependency>
> - <dependency>
> - <groupId>ch.qos.logback</groupId>
> - <artifactId>logback-classic</artifactId>
> - <version>1.3.11</version>
> - <scope>test</scope>
> - </dependency>
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>log4j-over-slf4j</artifactId>
> diff --git a/src/test/resources/logback.xml b/src/test/resources/logback.xml
> deleted file mode 100644
> index 88be419..0000000
> --- a/src/test/resources/logback.xml
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -<!--
> -
> - Copyright 2019 the original author or authors.
> -
> - Licensed under the Apache License, Version 2.0 (the "License");
> - you may not use this file except in compliance with the License.
> - You may obtain a copy of the License at
> -
> - http://www.apache.org/licenses/LICENSE-2.0
> -
> - Unless required by applicable law or agreed to in writing, software
> - distributed under the License is distributed on an "AS IS" BASIS,
> - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> - See the License for the specific language governing permissions and
> - limitations under the License.
> -
> --->
> -
> -<!--
> - | Local developer build logging configuration.
> - | * console log shows overall info+ build messages and project errors
> - | * overall build.log file includes all build log messages
> - | * project-specific build.log files include corresponding project build log messages
> - -->
> -<configuration>
> - <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator" />
> -
> - <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
> - <encoder>
> - <pattern>%-4relative [%thread] %-5level %logger{64} - %msg %n</pattern>
> - </encoder>
> - </appender>
> -
> - <logger name="org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy" level="debug"/>
> -
> - <root level="INFO">
> - <appender-ref ref="CONSOLE" />
> - </root>
> -
> -</configuration>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org