[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4376: [ISSUE #4375]Make some variables to be final.

[GitBox <gi...@apache.org>]

hzh0425 commented on code in PR #4376:
URL: https://github.com/apache/rocketmq/pull/4376#discussion_r882461160


##########
store/src/main/java/org/apache/rocketmq/store/index/IndexHeader.java:
##########
@@ -22,12 +22,12 @@
 
 public class IndexHeader {
     public static final int INDEX_HEADER_SIZE = 40;
-    private static int beginTimestampIndex = 0;
-    private static int endTimestampIndex = 8;
-    private static int beginPhyoffsetIndex = 16;
-    private static int endPhyoffsetIndex = 24;
-    private static int hashSlotcountIndex = 32;
-    private static int indexCountIndex = 36;
+    private static final int beginTimestampIndex = 0;
+    private static final int endTimestampIndex = 8;
+    private static final int beginPhyoffsetIndex = 16;
+    private static final int endPhyoffsetIndex = 24;
+    private static final int hashSlotcountIndex = 32;
+    private static final int indexCountIndex = 36;

Review Comment:
   This will not pass the ci format check, so it's best not to change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org