You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 00:38:40 UTC
[jira] [Created] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Correctly PreWarm HBCK ThreadPool
---------------------------------
Key: HBASE-4859
URL: https://issues.apache.org/jira/browse/HBASE-4859
Project: HBase
Issue Type: Bug
Reporter: Nicolas Spiegelberg
Assignee: Nicolas Spiegelberg
Fix For: 0.92.0, 0.94.0
See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156414#comment-13156414 ]
Ted Yu commented on HBASE-4859:
-------------------------------
+1 on patch.
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4859:
---------------------------------------
Attachment: HBASE-4859.patch
version 2 of the patch, modeled after HBASE-4859 behavior
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4859:
---------------------------------------
Attachment: HBASE-4859.patch
patch applies on 0.92 & 0.94
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4859:
-------------------------
Resolution: Fixed
Fix Version/s: (was: 0.92.1)
0.92.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed trunk and branch. Thank N.
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156482#comment-13156482 ]
Hadoop QA commented on HBASE-4859:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504951/HBASE-4859.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -162 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 66 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/357//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/357//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/357//console
This message is automatically generated.
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167050#comment-13167050 ]
Hudson commented on HBASE-4859:
-------------------------------
Integrated in HBase-TRUNK-security #27 (See [https://builds.apache.org/job/HBase-TRUNK-security/27/])
HBASE-4859 Correctly PreWarm HBCK ThreadPool
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4859:
---------------------------------------
Status: Patch Available (was: Open)
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166893#comment-13166893 ]
Hudson commented on HBASE-4859:
-------------------------------
Integrated in HBase-TRUNK #2535 (See [https://builds.apache.org/job/HBase-TRUNK/2535/])
HBASE-4859 Correctly PreWarm HBCK ThreadPool
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166864#comment-13166864 ]
Hudson commented on HBASE-4859:
-------------------------------
Integrated in HBase-0.92 #181 (See [https://builds.apache.org/job/HBase-0.92/181/])
HBASE-4859 Correctly PreWarm HBCK ThreadPool
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4859) Correctly PreWarm HBCK ThreadPool
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167064#comment-13167064 ]
Hudson commented on HBASE-4859:
-------------------------------
Integrated in HBase-0.92-security #35 (See [https://builds.apache.org/job/HBase-0.92-security/35/])
HBASE-4859 Correctly PreWarm HBCK ThreadPool
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> Correctly PreWarm HBCK ThreadPool
> ---------------------------------
>
> Key: HBASE-4859
> URL: https://issues.apache.org/jira/browse/HBASE-4859
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.92.0
>
> Attachments: HBASE-4859.patch, HBASE-4859.patch
>
>
> See description at HBASE-3553. We had a patch ready for this in HBASE-3620 but never applied it publicly. Testing showed massive speedup in HBCK, especially when RegionServers were down or had long response times.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira