You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org> on 2017/11/18 03:16:00 UTC
[jira] [Commented] (VALIDATOR-433) BigDecimalValidator does not
validate "()" negative currency uniformly for all locales
[ https://issues.apache.org/jira/browse/VALIDATOR-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257900#comment-16257900 ]
Bruno P. Kinoshita commented on VALIDATOR-433:
----------------------------------------------
Can you share a complete test case for that? The following code fails with US too, but not sure if you have similar code.
{code:java}
@Test
public void bigDecimalValidatorTest() {
BigDecimalValidator validator = new BigDecimalValidator();
final String US_DOLLAR = (new DecimalFormatSymbols(Locale.US)).getCurrencySymbol();
final String JAPAN_YEN = (new DecimalFormatSymbols(Locale.JAPAN)).getCurrencySymbol();
final String CHINA_YEN = (new DecimalFormatSymbols(Locale.CHINA)).getCurrencySymbol();
BigDecimal negative = new BigDecimal("-1234.56");
assertEquals("US negative", negative, validator.validate("(" + US_DOLLAR + "1,234.56)", Locale.US)); // fails
assertEquals("Japan negative", negative, validator.validate("(" + JAPAN_YEN + "1,234.56)", Locale.CHINA)); // fails
assertEquals("China negative", negative, validator.validate("(" + CHINA_YEN + "1,234.56)", Locale.CHINA)); // fails
}
{code}
> BigDecimalValidator does not validate "()" negative currency uniformly for all locales
> --------------------------------------------------------------------------------------
>
> Key: VALIDATOR-433
> URL: https://issues.apache.org/jira/browse/VALIDATOR-433
> Project: Commons Validator
> Issue Type: Bug
> Components: Routines
> Affects Versions: 1.6
> Environment: Windows 10, Tomcat 6, Java 8
> Reporter: John DiPirro
> Priority: Critical
>
> Hi,
> The following tests fail:
> final String JAPAN_YEN = (new DecimalFormatSymbols(Locale.JAPAN)).getCurrencySymbol();
> final String CHINA_YEN = (new DecimalFormatSymbols(Locale.CHINA)).getCurrencySymbol();
> BigDecimal negative = new BigDecimal("-1234.56");
> assertEquals("Japan negative", negative, validator.validate("(" + JAPAN_YEN + "1,234.56)", Locale.CHINA));
> assertEquals("China negative", negative, validator.validate("(" + CHINA_YEN + "1,234.56)", Locale.CHINA));
> Please not that this test do not fail for other locales (US AND UK, for example).
> Please advise on whether this is an issue, if there is a workaround, etc...
> Regards,
> John DiPirro
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)