[GitHub] [incubator-superset] ktmud commented on a change in pull request #9439: feat: change default time range from sql lab to no filter

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #9439: feat: change default time range from sql lab to no filter
URL: https://github.com/apache/incubator-superset/pull/9439#discussion_r403324626
 
 

 ##########
 File path: superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx
 ##########
 @@ -139,8 +139,8 @@ class ExploreResultsButton extends React.PureComponent {
           datasource: `${data.table_id}__table`,
           metrics: [],
           groupby: [],
+          time_range: 'No filter',
 
 Review comment:
   Agree this is not a good practice. There seems to be many other hard-coded time periods, as well. I am not comfortable with refactoring while changing the default or refactoring just the `'No filter'`. Maybe that refactoring can happen in a later PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org