[jira] [Commented] (MESOS-1712) Automate disallowing of commits mixing mesos/libprocess/stout

["Vinod Kone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173090#comment-14173090 ] 

Vinod Kone commented on MESOS-1712:
-----------------------------------

Here is what I think we should do.

Write a new (python) script (verify_split_commits.py?). This script takes a commit and returns an error if the commits are mixed.

This script should be called both by verify_reviews.py and git pre-commit commit hook. Alternatively, we could fold verify_split_commits into style.py (since it's called by both verify reviews and git commit hook) but not sure if this falls into style category.

> Automate disallowing of commits mixing mesos/libprocess/stout
> -------------------------------------------------------------
>
>                 Key: MESOS-1712
>                 URL: https://issues.apache.org/jira/browse/MESOS-1712
>             Project: Mesos
>          Issue Type: Bug
>          Components: reviewbot
>            Reporter: Vinod Kone
>            Assignee: Cody Maloney
>
> For various reasons, we don't want to mix mesos/libprocess/stout changes into a single commit. Typically, it is up to the reviewee/reviewer to catch this. 
> It wold be nice to automate this via the pre-commit hook .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)