You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/04/10 04:38:16 UTC

[spark] branch branch-3.0 updated: [SPARK-31401][K8S] Show JDK11 usage in `bin/docker-image-tool.sh`

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 8bac0ee  [SPARK-31401][K8S] Show JDK11 usage in `bin/docker-image-tool.sh`
8bac0ee is described below

commit 8bac0ee52a018b88324efc2a4ddbedfb3694b58f
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Thu Apr 9 21:36:26 2020 -0700

    [SPARK-31401][K8S] Show JDK11 usage in `bin/docker-image-tool.sh`
    
    ### What changes were proposed in this pull request?
    
    This PR adds an JDK11-based build example in `bin/docker-image-tool.sh`.
    
    ### Why are the changes needed?
    
    This helps the users migrate to JDK11 more easily.
    
    ### Does this PR introduce any user-facing change?
    
    Yes, but this is a usage help.
    
    ### How was this patch tested?
    
    First, check the help usage manually.
    ```
    $ bin/docker-image-tool.sh -h
    ...
      - Build and push JDK11-based image with tag "v3.0.0" to docker.io/myrepo
        bin/docker-image-tool.sh -r docker.io/myrepo -t v3.0.0 -b java_image_tag=11-jre-slim build
        bin/docker-image-tool.sh -r docker.io/myrepo -t v3.0.0 push {code}
    ```
    
    Then, build the image and check Java version.
    ```
    $ docker run -it --rm docker.io/myrepo/spark:v3.0.0 java --version | tail -n3
    openjdk 11.0.6 2020-01-14
    OpenJDK Runtime Environment 18.9 (build 11.0.6+10)
    OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode)
    ```
    
    Closes #28171 from dongjoon-hyun/SPARK-31401.
    
    Authored-by: Dongjoon Hyun <do...@apache.org>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
    (cherry picked from commit e42a3945acd614a26c7941a9eed161b500fb4520)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 bin/docker-image-tool.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bin/docker-image-tool.sh b/bin/docker-image-tool.sh
index 68fafbb..57b8625 100755
--- a/bin/docker-image-tool.sh
+++ b/bin/docker-image-tool.sh
@@ -248,6 +248,10 @@ Examples:
   - Build and push image with tag "v2.3.0" to docker.io/myrepo
     $0 -r docker.io/myrepo -t v2.3.0 build
     $0 -r docker.io/myrepo -t v2.3.0 push
+
+  - Build and push JDK11-based image with tag "v3.0.0" to docker.io/myrepo
+    $0 -r docker.io/myrepo -t v3.0.0 -b java_image_tag=11-jre-slim build
+    $0 -r docker.io/myrepo -t v3.0.0 push
 EOF
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org