You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "aritra24 (via GitHub)" <gi...@apache.org> on 2024/07/28 18:38:44 UTC
[PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
aritra24 opened a new pull request, #41083:
URL: https://github.com/apache/airflow/pull/41083
Changes the signature to yield tis instead of string repr of
tis
Fixes: #40490
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41083: Changes signature of cleanup_stuck_queued_tasks
URL: https://github.com/apache/airflow/pull/41083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #41083:
URL: https://github.com/apache/airflow/pull/41083#issuecomment-2345020740
Hey just saw this. lemme look at this next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #41083:
URL: https://github.com/apache/airflow/pull/41083#discussion_r1757645032
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1782,24 +1782,22 @@ def _fail_tasks_stuck_in_queued(self, session: Session = NEW_SESSION) -> None:
for executor, stuck_tis in self._executor_to_tis(tasks_stuck_in_queued).items():
try:
- cleaned_up_task_instances = set(executor.cleanup_stuck_queued_tasks(tis=stuck_tis))
- for ti in stuck_tis:
- if repr(ti) in cleaned_up_task_instances:
- self.log.warning(
- "Marking task instance %s stuck in queued as failed. "
- "If the task instance has available retries, it will be retried.",
- ti,
- )
- session.add(
- Log(
- event="stuck in queued",
- task_instance=ti.key,
- extra=(
- "Task will be marked as failed. If the task instance has "
- "available retries, it will be retried."
- ),
- )
+ for ti in executor.cleanup_stuck_queued_tasks(tis=stuck_tis):
+ self.log.warning(
+ "Marking task instance %s stuck in queued as failed. "
+ "If the task instance has available retries, it will be retried.",
+ ti,
+ )
+ session.add(
+ Log(
+ event="stuck in queued",
+ task_instance=ti.key,
Review Comment:
You may be tired but you are not missing something
We do need to handle backcompat unless we are going to bump min version to 3.0 at some point
Asked about that here https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1726148544916899
(And this pr is the motivation there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #41083:
URL: https://github.com/apache/airflow/pull/41083#discussion_r1757418273
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1782,24 +1782,22 @@ def _fail_tasks_stuck_in_queued(self, session: Session = NEW_SESSION) -> None:
for executor, stuck_tis in self._executor_to_tis(tasks_stuck_in_queued).items():
try:
- cleaned_up_task_instances = set(executor.cleanup_stuck_queued_tasks(tis=stuck_tis))
- for ti in stuck_tis:
- if repr(ti) in cleaned_up_task_instances:
- self.log.warning(
- "Marking task instance %s stuck in queued as failed. "
- "If the task instance has available retries, it will be retried.",
- ti,
- )
- session.add(
- Log(
- event="stuck in queued",
- task_instance=ti.key,
- extra=(
- "Task will be marked as failed. If the task instance has "
- "available retries, it will be retried."
- ),
- )
+ for ti in executor.cleanup_stuck_queued_tasks(tis=stuck_tis):
+ self.log.warning(
+ "Marking task instance %s stuck in queued as failed. "
+ "If the task instance has available retries, it will be retried.",
+ ti,
+ )
+ session.add(
+ Log(
+ event="stuck in queued",
+ task_instance=ti.key,
Review Comment:
I'm probably missing something (tired from 3 days of a conferences :sweat_smile:) Are we handling any back compat here? If this scheduler code runs with an old executor it's going to try use `ti` as if it's a TI object but it will be a string, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "aritra24 (via GitHub)" <gi...@apache.org>.
aritra24 commented on PR #41083:
URL: https://github.com/apache/airflow/pull/41083#issuecomment-2254607028
@dstandish does this kind of look like what you wanted wrt #40490?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41083:
URL: https://github.com/apache/airflow/pull/41083#issuecomment-2451055995
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes signature of cleanup_stuck_queued_tasks [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41083:
URL: https://github.com/apache/airflow/pull/41083#issuecomment-2345009663
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org