[jira] [Commented] (NIFI-5877) Protect against null ClusterStatus in HBase Client Service

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711964#comment-16711964 ] 

ASF GitHub Bot commented on NIFI-5877:
--------------------------------------

GitHub user bbende opened a pull request:

    https://github.com/apache/nifi/pull/3206

    NIFI-5877 Protecting against null values when obtaining master address

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbende/nifi hbase-npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3206
    
----
commit 10d2b6d2993a52207353257504fa22998add09b5
Author: Bryan Bende <bb...@...>
Date:   2018-12-06T16:45:26Z

    NIFI-5877 Protecting against null values when obtaining master address

----


> Protect against null ClusterStatus in HBase Client Service
> ----------------------------------------------------------
>
>                 Key: NIFI-5877
>                 URL: https://issues.apache.org/jira/browse/NIFI-5877
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.5.0, 1.6.0, 1.7.1
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>
> We currently get the masterAddress with this line of code:
> {code:java}
> masterAddress = admin.getClusterStatus().getMaster().getHostAndPort();{code}
> If getClusterStatus() returns null, or getMaster() returns null, then this code will throw a NPE and the service will fail to enable.
> We only user the masterAddress for the transit URI of provenance events, and we already protect against a blank/null masterAddress when generating the URI, so we should protect against the possible nulls in the line above.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)