Re: [bug] /abs/path/of/cwd/abs/path/of/target

[Noorul Islam K M <no...@collab.net>]

Daniel Shahaf <d....@daniel.shahaf.name> writes:

> Bogus path handling bug:
>
> [[[
> % svnadmin create r1
> % svnadmin create r2
> % svn co -q file://`pwd`/r1 wc1
> % svn co -q file://`pwd`/r2 wc2
>
> % ls -d *[12]
> r1  r2  wc1  wc2
> % touch wc2/iota
> % $svn add -q wc2/iota
> % cd wc1
>
> % pwd
> /tmp/svn/wc1
> % $svn di /tmp/svn/wc2/
> subversion/svn/diff-cmd.c:367: (apr_err=150000)
> subversion/libsvn_client/diff.c:1958: (apr_err=150000)
> subversion/libsvn_client/diff.c:1641: (apr_err=150000)
> subversion/libsvn_client/revisions.c:103: (apr_err=150000)
> svn: E150000: '/tmp/svn/wc1/tmp/svn/wc2' is not under version control
> zsh: exit 1     $svn di $(cd ..; pwd)/wc2/
> ]]]

It seems to be regression. This works in 1.6.

noorul@laptop:~$ cd /tmp
noorul@laptop:/tmp$ svnadmin create r1
noorul@laptop:/tmp$ svnadmin create r2
noorul@laptop:/tmp$ svn co -q file://`pwd`/r1 wc1
noorul@laptop:/tmp$ svn co -q file://`pwd`/r2 wc2

noorul@laptop:/tmp$ touch wc2/iota
noorul@laptop:/tmp$ svn add -q wc2/iota 

noorul@laptop:/tmp$ cd wc1
noorul@laptop:/tmp/wc1$ ls
noorul@laptop:/tmp/wc1$ pwd
/tmp/wc1
noorul@laptop:/tmp/wc1$ svn di /tmp/wc2
Index: /tmp/wc2/iota
===================================================================
noorul@laptop:/tmp/wc1$ svn di /tmp/wc2
Index: /tmp/wc2/iota
===================================================================

Shall I open an issue for this?

Thanks and Regards
Noorul

Re: [bug] /abs/path/of/cwd/abs/path/of/target

[Daniel Shahaf <d....@daniel.shahaf.name>]

Daniel Shahaf wrote on Wed, Mar 02, 2011 at 04:44:53 +0200:
> Noorul Islam K M wrote on Wed, Mar 02, 2011 at 07:15:02 +0530:
> > Shall I open an issue for this?
> 
> If you want to --- sure, that'll save me five minutes next week :-).
> Please set the milestone to 1.7.0 (it's a release blocker) and add the
> "bite-sized" keyword.  Also, could you CC me on the issue?

And, by the way, patches are welcome --- though, patch writers please
note Hyrum's ongoing work on "Which paths are wcroots?" caching, which
might (or might not) be related.

Re: [bug] /abs/path/of/cwd/abs/path/of/target

[Daniel Shahaf <d....@daniel.shahaf.name>]

Noorul Islam K M wrote on Wed, Mar 02, 2011 at 07:15:02 +0530:
> Daniel Shahaf <d....@daniel.shahaf.name> writes:
> > Bogus path handling bug:
> >
> > [[[
> > % pwd
> > /tmp/svn/wc1
> > % $svn di /tmp/svn/wc2/
> > svn: E150000: '/tmp/svn/wc1/tmp/svn/wc2' is not under version control
> 
> It seems to be regression. This works in 1.6.

I'm not surprised by that, but thanks for double-checking.  (It'll be
more interesting to figure out until when it worked on trunk; svn-bisect
should be useful here.)

> Shall I open an issue for this?
> 

If you want to --- sure, that'll save me five minutes next week :-).
Please set the milestone to 1.7.0 (it's a release blocker) and add the
"bite-sized" keyword.  Also, could you CC me on the issue?

> Thanks and Regards
> Noorul

Thanks!

Daniel