[GitHub] [arrow-datafusion] andygrove commented on issue #2278: LogicalPlanBuilder::scan_csv creates scans with invalid table names

[GitBox <gi...@apache.org>]

andygrove commented on issue #2278:
URL: https://github.com/apache/arrow-datafusion/issues/2278#issuecomment-1113753014

   Sorry, just catching up here. This issue came up when I was attempting to refactor DF to have the plan just refer to table sources by name, and this would require names to be valid SQL object names. I eventually gave up on the refactor because I ran into too many places where our design really doesn't support this.
   
   Fundamentally, file scans don't have table names, but we store the path in an attribute named `table_name`. Perhaps a better approach here would be to introduce a `LogicalPlan::FileScan` which would be almost identical to `LogicalPlan::TableScan` but with `file_path` instead of `table_name`? Over time we could have `FileScan` and `TableScan` diverge as needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org