You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/16 23:36:18 UTC

[GitHub] [beam] scwhittle commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…

scwhittle commented on issue #11442: [BEAM-9773]: Update Dataflow Debug Capture to use Google API client J…
URL: https://github.com/apache/beam/pull/11442#issuecomment-614949937
 
 
   Thanks! I think that the description would be better if it included why the test passes without this change and where this causes a failure.  IIRC you mentioned that you had to add some logging to see this was what was causing the failure. Can you include that logging in the PR too?
   
   I'm also not a merger so maybe ask reuvenlax after making those changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services