You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/07 21:25:23 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19310: fix numpy ediff1d large tensor
Zha0q1 opened a new pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310
This pr enables large tensor support for np.ediff1d
local run:
```
ubuntu@ip-172-31-38-169:~/incubator-mxnet$ pytest tests/nightly/test_np_large_array.py::test_ediff1d
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
================================================ test session starts ================================================
platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
collected 1 item
tests/nightly/test_np_large_array.py . [100%]
================================================= warnings summary ==================================================
tests/nightly/test_np_large_array.py:92
/home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:92: DeprecationWarning: invalid escape sequence \
'''
tests/nightly/test_np_large_array.py:1225
/home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:1225: DeprecationWarning: invalid escape sequence \
'''
-- Docs: https://docs.pytest.org/en/latest/warnings.html
========================================== 1 passed, 2 warnings in 45.35s =====================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#discussion_r505941746
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2001,3 +2001,19 @@ def test_vstack():
assert out2[0, -1] == 0 and out2[1, -1] == 1
assert inp2.grad.shape == inp2.shape
assert inp2.grad[-1, -1] == 1
+
+
+@use_np
+def test_ediff1d():
+ INT_OVERFLOW = 2**31
+ inp = np.zeros((2, INT_OVERFLOW))
+ inp[0, -1], inp[1, 0] = 1, 3
+ inp.attach_grad()
+ with mx.autograd.record():
+ out = np.ediff1d(inp, to_begin=-99, to_end=np.array([88, 99]))
+ out.backward()
+ assert out.shape == (2*INT_OVERFLOW-1+1+2, )
Review comment:
nit: space b/w ops ? Is this according to PEP8 style ? Rest LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-710689879
@mxnet-bot run ci [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-710698613
Jenkins CI successfully triggered : [edge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709651629
None of the jobs entered are supported.
Jobs entered by user: [unic-cpu]
CI supported Jobs: [website, clang, sanity, centos-cpu, unix-gpu, unix-cpu, miscellaneous, edge, centos-gpu, windows-cpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-705767722
@access2rohit @mseth10 can you review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 edited a comment on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 edited a comment on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709661408
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709661408
@mxnet-bot run ci [unic-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709661414
None of the jobs entered are supported.
Jobs entered by user: [unic-cpu]
CI supported Jobs: [clang, unix-cpu, sanity, windows-cpu, miscellaneous, centos-gpu, website, centos-cpu, edge, windows-gpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-710689901
Jenkins CI successfully triggered : [unix-gpu, edge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709651603
@mxnet-bot run ci [unic-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-710698605
@mxnet-bot run ci [edge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-709661527
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-705202516
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, edge, centos-gpu, miscellaneous, centos-cpu, unix-gpu, windows-cpu, clang, sanity, unix-cpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19310: fix numpy ediff1d large tensor
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19310:
URL: https://github.com/apache/incubator-mxnet/pull/19310#issuecomment-705767722
@access2rohit @mseth10 can you review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org