You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/07/27 17:07:36 UTC
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23218
Change subject: [tserver] more detailed trace on early scan response
......................................................................
[tserver] more detailed trace on early scan response
This patch adds more details into the traces emitted on early scan
responses. I also sneaked in a fix for a potential integer overflow
in ColumnarResultSerializer::ResponseSize() when using larger column
cells. Also, a non-OK status from Iterator::NextBlock() is now logged
as error, not warning, since it's expected to error out only in case of
corruption and other unexpected server-side conditions.
This changelist doesn't contain any functional modifications.
Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Reviewed-on: http://gerrit.cloudera.org:8080/23214
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 73a4adc889863e3194fe97d7f75cc1198dfa4569)
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 15 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/23218/1
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1616/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 11:07:30 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Patch Set 1: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1616/
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 09:15:24 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Patch Set 1: Verified+1 Code-Review+2
unrelated test failures:
releases: raft_consensus-itest.0
asan: maintenance_mode-itest.6
tsan: txn_participant-test.0, org.apache.kudu.client.TestSecurity
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:35:34 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
[tserver] more detailed trace on early scan response
This patch adds more details into the traces emitted on early scan
responses. I also sneaked in a fix for a potential integer overflow
in ColumnarResultSerializer::ResponseSize() when using larger column
cells. Also, a non-OK status from Iterator::NextBlock() is now logged
as error, not warning, since it's expected to error out only in case of
corruption and other unexpected server-side conditions.
This changelist doesn't contain any functional modifications.
Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Reviewed-on: http://gerrit.cloudera.org:8080/23214
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 73a4adc889863e3194fe97d7f75cc1198dfa4569)
Reviewed-on: http://gerrit.cloudera.org:8080/23218
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 15 insertions(+), 14 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1614/
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 17:07:50 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tserver] more detailed trace on early scan response
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23218 )
Change subject: [tserver] more detailed trace on early scan response
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1614/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb171fcf46b4d8534e7d8f933b3b0594f940ace1
Gerrit-Change-Number: 23218
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 18:20:51 +0000
Gerrit-HasComments: No