You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/13 13:46:08 UTC
Review Request 68321: Add '/state-summary' to batched master
endpoints.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
Add '/state-summary' to batched master endpoints.
Diffs
-----
src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8
src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11
Diff: https://reviews.apache.org/r/68321/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207155
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 68296.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68296`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2138/mesos-review-68321
- Mesos Reviewbot Windows
On Aug. 13, 2018, 1:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8
> src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11
>
>
> Diff: https://reviews.apache.org/r/68321/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207534
-----------------------------------------------------------
Ship it!
Great to see more progress here! Approach looks good to me.
- Benjamin Mahler
On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207548
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68342', '68343', '68378', '68296', '68321']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2189/mesos-review-68321
Relevant logs:
- [mesos-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2189/mesos-review-68321/logs/mesos-tests-cmake.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (20) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\master\http.cpp(3022): error C2065: 'batchedStateRequests': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\http.cpp(3022): error C2228: left of '.empty' must have class/struct/union [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
2 Error(s)
Time Elapsed 00:14:00.64
```
- Mesos Reviewbot Windows
On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207608
-----------------------------------------------------------
src/master/master.hpp
Lines 1410-1425 (patched)
<https://reviews.apache.org/r/68321/#comment291062>
Do you plan to augment this review or pull these additions into separate review(s)?
- Alexander Rukletsov
On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 10:27 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Changes
-------
Rebased onto latest master.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs (updated)
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
Diff: https://reviews.apache.org/r/68321/diff/4/
Changes: https://reviews.apache.org/r/68321/diff/3-4/
Testing
-------
See https://reviews.apache.org/r/68473/
Thanks,
Benno Evers
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 10:06 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
Diff: https://reviews.apache.org/r/68321/diff/3/
Testing (updated)
-------
https://reviews.apache.org/r/68473/
Thanks,
Benno Evers
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 3476 (original), 3487 (patched)
> > <https://reviews.apache.org/r/68321/diff/3/?file=2075651#file2075651line3487>
> >
> > `return std::move(OK(...));`
Dropping this since we agreed in offline discussions that it would not make a difference.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207956
-----------------------------------------------------------
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/state-summary' to the set of batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
>
>
> Diff: https://reviews.apache.org/r/68321/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207956
-----------------------------------------------------------
Fix it, then Ship it!
Looks good to me (modulo testing).
src/master/http.cpp
Line 3476 (original), 3487 (patched)
<https://reviews.apache.org/r/68321/#comment291623>
`return std::move(OK(...));`
- Alexander Rukletsov
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/state-summary' to the set of batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
>
>
> Diff: https://reviews.apache.org/r/68321/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 2:09 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Summary (updated)
-----------------
Added '/state-summary' to the set of batched master endpoints.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description (updated)
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs (updated)
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
Diff: https://reviews.apache.org/r/68321/diff/3/
Changes: https://reviews.apache.org/r/68321/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207653
-----------------------------------------------------------
PASS: Mesos patch 68321 was successfully built and tested.
Reviews applied: `['68321']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2202/mesos-review-68321
- Mesos Reviewbot Windows
On Aug. 21, 2018, 6:45 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 6:45 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207651
-----------------------------------------------------------
Bad patch!
Reviews applied: [68321]
Failed command: python support/apply-reviews.py -n -r 68321
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-21 07:00:43 URL:https://reviews.apache.org/r/68321/diff/raw/ [15246/15246] -> "68321.patch" [1]
error: patch failed: src/master/master.hpp:1399
error: src/master/master.hpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23130/console
- Mesos Reviewbot
On Aug. 21, 2018, 6:45 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 6:45 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:45 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Add '/state-summary' to batched master endpoints.
Diffs
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68321/diff/2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:44 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
Add '/state-summary' to batched master endpoints.
Diffs
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68321/diff/2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207574
-----------------------------------------------------------
Bad review!
Reviews applied: [68321, 68296]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Aug. 17, 2018, 12:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 12:03 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 21, 2018, 6:27 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp
> > Lines 1401-1404 (original), 1401-1410 (patched)
> > <https://reviews.apache.org/r/68321/diff/2/?file=2074732#file2074732line1401>
> >
> > How about moving definitions on this class's methods to a separate file, e.g., "readonly_handlers.cpp"?
Sounds good, but I'll do it bundled at the end of the review chain.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207650
-----------------------------------------------------------
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/state-summary' to the set of batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
>
>
> Diff: https://reviews.apache.org/r/68321/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207650
-----------------------------------------------------------
src/master/master.hpp
Lines 1401-1404 (original), 1401-1410 (patched)
<https://reviews.apache.org/r/68321/#comment291086>
How about moving definitions on this class's methods to a separate file, e.g., "readonly_handlers.cpp"?
- Alexander Rukletsov
On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:03 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68321/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 7:03 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
Add '/state-summary' to batched master endpoints.
Diffs (updated)
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68321/diff/2/
Changes: https://reviews.apache.org/r/68321/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207411
-----------------------------------------------------------
src/master/http.cpp
Line 3305 (original), 3305 (patched)
<https://reviews.apache.org/r/68321/#comment290801>
It can remain const!
- Alexander Rukletsov
On Aug. 13, 2018, 1:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8
> src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11
>
>
> Diff: https://reviews.apache.org/r/68321/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Add '/state-summary' to batched master
endpoints.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207170
-----------------------------------------------------------
Bad patch!
Reviews applied: [68321, 68296]
Failed command: python support/apply-reviews.py -n -r 68296
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-13 22:03:16 URL:https://reviews.apache.org/r/68296/diff/raw/ [12794/12794] -> "68296.patch" [1]
error: patch failed: src/master/http.cpp:2843
error: src/master/http.cpp: patch does not apply
error: patch failed: src/master/master.hpp:1845
error: src/master/master.hpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23063/console
- Mesos Reviewbot
On Aug. 13, 2018, 1:46 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add '/state-summary' to batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8
> src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11
>
>
> Diff: https://reviews.apache.org/r/68321/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>