You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Victor Igumnov (JIRA)" <ji...@apache.org> on 2007/12/29 08:54:43 UTC
[jira] Created: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks.
modal.js conflicts with mootools and possibly other javascript frameworks.
--------------------------------------------------------------------------
Key: WICKET-1249
URL: https://issues.apache.org/jira/browse/WICKET-1249
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.3.0-rc2
Environment: linux / jdk 1.6 etc
Reporter: Victor Igumnov
Fix For: 1.3.0-rc3
Modal.js issues
1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks.
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1249:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.1
> modal.js conflicts with mootools and possibly other javascript frameworks.
> --------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Fix For: 1.3.1
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks. + patch fix
Posted by "Victor Igumnov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Igumnov updated WICKET-1249:
-----------------------------------
Attachment: modalconflictfix.patch
patch fix
> modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Assignee: Matej Knopp
> Fix For: 1.3.1
>
> Attachments: modalconflictfix.patch
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks. + patch fix
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1249:
-------------------------------------
Assignee: Matej Knopp
> modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Assignee: Matej Knopp
> Fix For: 1.3.1
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1249) modal.js conflicts with mootools
and possibly other javascript frameworks. + patch fix
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555835#action_12555835 ]
Igor Vaynberg commented on WICKET-1249:
---------------------------------------
it would be great if you could attach that patch to this jira issue as an attachment and check the "attach under asl2" attachment option. that makes it much easier licensing wise for us to integrate that patch directly.
> modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Assignee: Matej Knopp
> Fix For: 1.3.1
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks. + patch fix
Posted by "Victor Igumnov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Igumnov updated WICKET-1249:
-----------------------------------
Summary: modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix (was: modal.js conflicts with mootools and possibly other javascript frameworks.)
> modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Fix For: 1.3.1
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1249) modal.js conflicts with mootools and
possibly other javascript frameworks. + patch fix
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp resolved WICKET-1249.
---------------------------------
Resolution: Fixed
> modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1249
> URL: https://issues.apache.org/jira/browse/WICKET-1249
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc2
> Environment: linux / jdk 1.6 etc
> Reporter: Victor Igumnov
> Assignee: Matej Knopp
> Fix For: 1.3.1
>
> Attachments: modalconflictfix.patch
>
>
> Modal.js issues
> 1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
> 2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.
> Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk
> http://temp.fabulously40.com/~victori/modalconflictfix.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.