You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/10/25 17:55:09 UTC
[GitHub] tinkerpop pull request #463: TINKERPOP-919 Added supportsIdenticalMultiPrope...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/463
TINKERPOP-919 Added supportsIdenticalMultiProperties()
https://issues.apache.org/jira/browse/TINKERPOP-919
That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key. Not sure why this wasn't implemented long ago. It was relatively straightforward to put in place. I did take a look at the test suite for existing tests that might have needed this feature included, but I didn't see any.
`mvn clean install -DincludeNeo4j` is all good
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit ead13106981bc019be25b66e0e432741c3646a2f
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-10-25T17:50:48Z
TINKERPOP-919 Added supportsIdenticalMultiProperties()
That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsIdenticalMultiProperties()
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/463
i played with a lot of different words. "duplicate" was one. i don't mind changing it if you like that better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsDuplicateMultiProperties()
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/463
ok - renamed to use "duplicate" and rebased on tp32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsIdenticalMultiProperties()
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/463
I was a confused for a bit on the method name. Seems (and this is just me) that a better name would be:
```
Features.supportsDuplicateMultiPropertyValues()
```
To me this means same key, duplicate values. The problem with "identical" is that there is no such thing as identical as properties can have meta-properties and be different. Thus, its a key/value identity, not a key/value/properties/id identity.
Dunno...whateves.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #463: TINKERPOP-919 Added supportsDuplicateMultiPrope...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsDuplicateMultiProperties()
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/463
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsDuplicateMultiProperties()
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/463
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---