[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15026: [Test]branch-2.9: fixed eror test case at AdminApiTest2

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #15026:
URL: https://github.com/apache/pulsar/pull/15026#discussion_r842054582


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -458,8 +461,12 @@ protected void internalDeleteNamespaceForcefully(AsyncResponse asyncResponse, bo
             for (NamespaceBundle bundle : bundles.getBundles()) {
                 // check if the bundle is owned by any broker, if not then we do not need to delete the bundle
                 if (pulsar().getNamespaceService().getOwner(bundle).isPresent()) {
-                    futures.add(pulsar().getAdminClient().namespaces()
-                            .deleteNamespaceBundleAsync(namespaceName.toString(), bundle.getBundleRange(), true));
+                    CompletableFuture<Void> futureForDeleteBundle = FutureUtil.waitForAll(futuresForDeleteTopics)

Review Comment:
   Forcibly delete the order of topics and bundles, becase after deleted bundles, the topic will be fenced, then the operation that delete topic will failure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org