[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6964: fixed GenericRow compare for different _fieldToValueMap size

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638342878



##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/GenericRowTest.java
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.data.readers;
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+public class GenericRowTest {
+
+  @Test
+  public void testEmptyRowsEqual() {
+    GenericRow first = new GenericRow();
+    GenericRow second = new GenericRow();
+    Assert.assertEquals(first, second);
+  }
+
+  @Test
+  public void testEmptyRowNotEqualToNonEmptyRow() {
+    GenericRow first = new GenericRow();
+    GenericRow second = new GenericRow();
+    second.putValue("one", 1);
+    Assert.assertNotEquals(first, second);
+  }
+
+  @Test
+  public void testRowDifferentValueNotEqual() {
+    GenericRow first = new GenericRow();
+    first.putValue("one", 1);
+    GenericRow second = new GenericRow();
+    second.putValue("one", "one");
+    Assert.assertNotEquals(first, second);
+  }
+
+  @Test
+  public void testDifferentNumberOfKeysWithSomeSameValueNotEqual() {
+    GenericRow first = new GenericRow();
+    first.putValue("one", 1);
+    first.putValue("two", 2);
+    GenericRow second = new GenericRow();
+    second.putValue("one", 1);
+    Assert.assertNotEquals(first, second);
+  }
+
+  @Test
+  public void testDifferentNumberOfKeysWithNoSameValueNotEqual() {
+    GenericRow first = new GenericRow();
+    first.putValue("one", 1);
+    first.putValue("two", 2);
+    GenericRow second = new GenericRow();
+    second.putValue("one", "one");
+    Assert.assertNotEquals(first, second);
+  }
+
+  @Test
+  public void testNullAndNonNullValuesNotEqual() {
+    GenericRow first = new GenericRow();
+    first.putValue("one", null);
+    GenericRow second = new GenericRow();
+    second.putValue("one", 1);
+    Assert.assertNotEquals(first, second);
+
+    first = new GenericRow();
+    first.putValue("one", 1);
+    second = new GenericRow();
+    second.putValue("one", null);
+    Assert.assertNotEquals(first, second);
+  }
+
+  @Test
+  public void testIntValuesEqual() {
+    GenericRow first = new GenericRow();
+    first.putValue("one", 1);
+    GenericRow second = new GenericRow();
+    second.putValue("one", 1);
+    Assert.assertEquals(first, second);
+  }
+}

Review comment:
       (nit) new line

##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/data/readers/GenericRowTest.java
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.data.readers;
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+public class GenericRowTest {

Review comment:
       Please add a test on the Map field value, which can catch the bug fixed in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org