[jira] [Commented] (BOOKKEEPER-911) Fix TestReplicationWorker tests in master

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223116#comment-15223116 ] 

Rakesh R commented on BOOKKEEPER-911:
-------------------------------------

Thanks [~arunmk] for working on this. I could see BOOKKEEPER-594 has changed the {{ReplicationWorker#run()}} exception handling behaviors. We could modify the tests by enabling {{BookKeeperClusterTestCase#setAutoRecoveryEnabled(true)}} and expire the zk session rather than simply stopping zk cluster. Probably you can refer [TestBookieWatcher.java#L96|https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestBookieWatcher.java#L96] to signal zk session expired in BK tests.

> Fix TestReplicationWorker tests in master
> -----------------------------------------
>
>                 Key: BOOKKEEPER-911
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-911
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.3.2
>            Reporter: Arun M. Krishnakumar
>            Assignee: Arun M. Krishnakumar
>            Priority: Minor
>
> Currently we have the following test failures in master branch:
> Results :
> Failed tests:   testRWZKSessionLost[0](org.apache.bookkeeper.replication.TestReplicationWorker): Replication worker should have shut down
>   testRWZKSessionLost[1](org.apache.bookkeeper.replication.TestReplicationWorker): Replication worker should have shut down
>   testRWZKSessionLost[2](org.apache.bookkeeper.replication.TestReplicationWorker): Replication worker should have shut down
> Tests in error: 
>   testRWShutdownOnLocalBookieReadonlyTransition[0](org.apache.bookkeeper.replication.TestReplicationWorker): test timed out after 20000 milliseconds
>   testRWShutdownOnLocalBookieReadonlyTransition[1](org.apache.bookkeeper.replication.TestReplicationWorker): test timed out after 20000 milliseconds
>   testRWShutdownOnLocalBookieReadonlyTransition[2](org.apache.bookkeeper.replication.TestReplicationWorker): test timed out after 20000 milliseconds
> Tests run: 654, Failures: 3, Errors: 3, Skipped: 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)