You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/12 05:18:27 UTC

[GitHub] [maven-jar-plugin] olamy commented on a diff in pull request #47: Code simplifications in AbstractMojo

olamy commented on code in PR #47:
URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r944120213


##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String classifi
             throw new IllegalArgumentException( "finalName is not allowed to be null" );
         }
 
-        StringBuilder fileName = new StringBuilder( resultFinalName );
-
+        final String fileName;

Review Comment:
   @rhowe great. Thanks! Still on final to remove  ;) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org