[jira] [Work logged] (LANG-1557) change a Pattern to a static final field, for not letting it compile each time the function invoked.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1557?focusedWorklogId=445361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445361 ]

ASF GitHub Bot logged work on LANG-1557:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jun/20 15:00
            Start Date: 13/Jun/20 15:00
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439745405



##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String stripChars) {
         return stripEnd(str, stripChars);
     }
 
+    private static final Pattern STRIP_ACCENTS_PATTERN = Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$

Review comment:
       All constants live at the top of the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 445361)
    Remaining Estimate: 0h
            Time Spent: 10m

> change a Pattern to a static final field, for not letting it compile each time the function invoked.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LANG-1557
>                 URL: https://issues.apache.org/jira/browse/LANG-1557
>             Project: Commons Lang
>          Issue Type: Sub-task
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/542]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)