You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/05 18:25:15 UTC

[GitHub] [commons-math] aherbert commented on a change in pull request #193: Simplify improvements:

aherbert commented on a change in pull request #193:
URL: https://github.com/apache/commons-math/pull/193#discussion_r683685310



##########
File path: commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/SimpleCurveFitter.java
##########
@@ -187,10 +187,7 @@ public int compare(WeightedObservedPoint p1,
                         return comp;
                     }
                     comp = Double.compare(p1.getWeight(), p2.getWeight());

Review comment:
       No need to store the result in `comp`. Just return the result direct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org