[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3931: renames the override role and extends it to ds request completion and…

[GitBox <gi...@apache.org>]

mitchell852 opened a new pull request #3931: renames the override role and extends it to ds request completion and…
URL: https://github.com/apache/trafficcontrol/pull/3931
 
 
   … rejection
   
   ## What does this PR (Pull Request) do?
   
   Allows users with the admin role to mark fulfilled delivery services requests as "complete".  Before this change, only the user that fulfilled the delivery service request could mark it as "complete". This can cause problems if the fulfilling user is not available to mark it as complete thus leaving the delivery service request in an "open" state. Because a delivery service can only have one open ds request at a time, this would block any further changes to a delivery service. Now anyone with the admin role can "complete" ds requests and unblock the delivery service from future updates.
   
   - [ ] This PR fixes #3871 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   - enable ds requests in traffic_portal_properties.json
   - launch TP
   - login as user 1 (with portal role or higher) and update a delivery service which will create a delivery service request and set the request status to 'submit request for review and deployment'
   - login as user 2 (with operations role or higher) and fulfill the delivery service request
   - login as user 3 (with admin role) and mark the delivery service request as "complete"
   
   (before this change, only user 2 (the fulfiller of the ds request) could mark the ds request as complete)
   
   There are no UI tests to cover ds requests currently as ds requests are disabled by default and no mechanism to turn them on for testing.
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation is unnecessary
   - [] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services