You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/23 10:32:43 UTC

[GitHub] [spark] tech4242 edited a comment on issue #27987: [SPARK-31165] Correcting wrong paths in Dockerfile

tech4242 edited a comment on issue #27987: [SPARK-31165] Correcting wrong paths in Dockerfile
URL: https://github.com/apache/spark/pull/27987#issuecomment-602511147
 
 
   @yaooqinn thanks for reaching out! :) 2 questions from my side:
   
   1) How is the `/kubernetes/ ` path for the resources (in the Dockerfile) ever going to be correct if one is supposed to run this from the root folder (as described in the Dockerfile comment) if all the files are under `/resource-managers/kubernetes/...` and if you e.g. build from source does the folder `/integration-tests/ `suddenly turn to `/tests/` ? I still feel like there are inconsistencies? I feel like your comment might only address the jars folder but for that I would need an answer to 2) below.
   
   2) Do you mean that basically building with `./build/mvn -Pkubernetes -DskipTests clean package` first is pointless or not intended? If that is the case then the documentation should at least be updated or made a bit easier to understand and I do think that the Dockerfile comment at the beginning of the file is also confusing.
   
   Open to suggestions though - I am just trying to wrap my head around the intended behaviour of this Dockerfile and how it can possible run out of the box.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org