You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vinodkc <gi...@git.apache.org> on 2017/04/28 05:00:19 UTC
[GitHub] storm pull request #2093: STORM-2495:Integrate checkstyle check during build
GitHub user vinodkc opened a pull request:
https://github.com/apache/storm/pull/2093
STORM-2495:Integrate checkstyle check during build
Integrated checkstyle in maven validate phase.Added google java style check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinodkc/storm-1 br_integrateCheckStyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2093
----
commit e1cf91258cfdea227857995a5eaff081b71232c7
Author: vinodkc <vi...@gmail.com>
Date: 2017-04-28T04:31:53Z
Integrated checkstyle in maven validate phase.Added google java style check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2093
@revans2 , I've redirected the warnings to files and added maxAllowedViolations for each project with their current number of violations.
Shall add an umbrella JIRA which contains multiple JIRA sub tasks to handle errors and warnings in each project?
Then I shall add JIRA reference in corresponding pom.xml files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
@vinodkc Looks good we are likely going to need to modify the total number of violations when this is ready to be merged in.
I would love to see something that can find the checkstyle-result.xml that caused a failure (or at least has some of the failures in it) and will output some of the violations. But that may be above and beyond.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2093
Due to new checkstyle warnings, size of build log file exceeded 4mb limit.
Error from build
"The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over)."
Can we increase the log size limit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
@vinodkc We cannot increase the size of the log without paying money to travisci, or switching the build to the internal Jenkins servers at apache. The later has been proposed but is not likely to happen soon.
My advice would be to set the useFile config to move the warnings to a text file that we can output the first X lines of if the build fails. Then add in a maxAllowedViolations for each project with their current number of violations along with a JIRA to fix the warnings in the project and remove the limit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2093: STORM-2495:Integrate checkstyle check during build
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---